Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2769)

Unified Diff: chrome/browser/component_updater/pnacl/pnacl_updater_observer.h

Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sorin review 2 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/pnacl/pnacl_updater_observer.h
diff --git a/chrome/browser/component_updater/pnacl/pnacl_updater_observer.h b/chrome/browser/component_updater/pnacl/pnacl_updater_observer.h
index 48a6f0d9c81cbceb527da5478be4d0220ec1638f..aa00ca2bf5057e364f517b003384cf35beb9f4d7 100644
--- a/chrome/browser/component_updater/pnacl/pnacl_updater_observer.h
+++ b/chrome/browser/component_updater/pnacl/pnacl_updater_observer.h
@@ -6,25 +6,24 @@
#define CHROME_BROWSER_COMPONENT_UPDATER_PNACL_PNACL_UPDATER_OBSERVER_H_
#include "base/compiler_specific.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
+#include "chrome/browser/component_updater/component_updater_service.h"
class PnaclComponentInstaller;
// Monitors the component updater service, so that the callbacks registered
// against the PnaclComponentInstaller can be notified of events.
-class PnaclUpdaterObserver : public content::NotificationObserver {
+class PnaclUpdaterObserver : public ComponentObserver {
public:
- explicit PnaclUpdaterObserver(PnaclComponentInstaller* installer);
+ explicit PnaclUpdaterObserver(PnaclComponentInstaller* pci);
virtual ~PnaclUpdaterObserver();
- virtual void Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
+ virtual void OnEvent(Events event, int extra) OVERRIDE;
+
+ void EnsureObserving();
+ void StopObserving();
private:
- content::NotificationRegistrar registrar_;
+ bool must_observe_;
PnaclComponentInstaller* pnacl_installer_;
DISALLOW_COPY_AND_ASSIGN(PnaclUpdaterObserver);
};

Powered by Google App Engine
This is Rietveld 408576698