Consistently use notifications from component updater w/ on-demand PNaCl.

chrome/browser/component_updater/component_updater_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/version.h"
 #include "googleurl/src/gurl.h"
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 namespace base {
 class DictionaryValue;
 class FilePath;
 }
 
+namespace content {
+class NotificationSource;
+}
+
 class ComponentPatcher;
 
 // Component specific installers must derive from this class and implement
 // OnUpdateError() and Install(). A valid instance of this class must be
 // given to ComponentUpdateService::RegisterComponent().
 class ComponentInstaller {
  public :
   // Called by the component updater on the UI thread when there was a
   // problem unpacking or verifying the component. |error| is a non-zero
   // value which is only meaningful to the component updater.
@@ skipping 116 matching lines @@
   // registered component, soon. If an update or check is already in progress,
   // returns |kInProgress|. The same component cannot be checked repeatedly
   // in a short interval either (returns |kError| if so).
   // There is no guarantee that the item will actually be updated,
   // since another item may be chosen to be updated. Since there is
   // no time guarantee, there is no notification if the item is not updated.
   // However, the ComponentInstaller should know if an update succeeded
   // via the Install() hook.
   virtual Status CheckForUpdateSoon(const CrxComponent& component) = 0;
 
+  // Return true if a NOTIFICATION_COMPONENT_UPDATE_FOUND or
+  // NOTIFICATION_COMPONENT_UPDATE_READY is for the given component.
+  static bool IsUpdateNotificationForComponent(
+      const content::NotificationSource& src,
+      const CrxComponent& component);

[Sorin Jianu, 2013/07/03 21:17:32]

This static member seems out of place in the definition of
ComponentUpdateService, which is a abstract class. Having a statric member here
could also make mocking of the class difficult in the future.

[jvoung (off chromium), 2013/07/03 22:51:51]

Ah good point. Changed to non-static.

+
   virtual ~ComponentUpdateService() {}
 };
 
 // Creates the component updater. You must pass a valid |config| allocated on
 // the heap which the component updater will own.
 ComponentUpdateService* ComponentUpdateServiceFactory(
     ComponentUpdateService::Configurator* config);
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_