Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 180053003: Fix mjsunit/compiler/concurrent-invalidate-transition-map.js test. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix mjsunit/compiler/concurrent-invalidate-transition-map.js test. BUG=v8:3156 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20009

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M test/mjsunit/compiler/concurrent-invalidate-transition-map.js View 1 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ulan
PTAL https://codereview.chromium.org/180053003/diff/1/test/mjsunit/compiler/concurrent-invalidate-transition-map.js File test/mjsunit/compiler/concurrent-invalidate-transition-map.js (right): https://codereview.chromium.org/180053003/diff/1/test/mjsunit/compiler/concurrent-invalidate-transition-map.js#newcode47 test/mjsunit/compiler/concurrent-invalidate-transition-map.js:47: add_field(obj); If GC happens between the calls and ...
6 years, 10 months ago (2014-02-25 17:44:28 UTC) #1
Yang
On 2014/02/25 17:44:28, ulan wrote: > PTAL > > https://codereview.chromium.org/180053003/diff/1/test/mjsunit/compiler/concurrent-invalidate-transition-map.js > File test/mjsunit/compiler/concurrent-invalidate-transition-map.js (right): > ...
6 years, 10 months ago (2014-02-25 17:46:21 UTC) #2
Yang
On 2014/02/25 17:46:21, Yang wrote: > On 2014/02/25 17:44:28, ulan wrote: > > PTAL > ...
6 years, 9 months ago (2014-03-13 11:57:38 UTC) #3
Yang
On 2014/03/13 11:57:38, Yang wrote: > On 2014/02/25 17:46:21, Yang wrote: > > On 2014/02/25 ...
6 years, 9 months ago (2014-03-17 16:04:08 UTC) #4
ulan
On 2014/03/17 16:04:08, Yang wrote: > On 2014/03/13 11:57:38, Yang wrote: > > On 2014/02/25 ...
6 years, 9 months ago (2014-03-17 16:12:02 UTC) #5
ulan
6 years, 9 months ago (2014-03-17 17:00:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r20009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698