Issue 180051: linux: fix some plugin colormap leaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180051: linux: fix some plugin colormap leaks (Closed)

Created:
11 years, 3 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: fix some plugin colormap leaks This code was wrong from the start; I know better now. TEST=windowless plugins still draw (I tried in in test_shell) BUG=19238

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl_gtk.cc	View		4 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

(on that test page from the bug see no memory leak, but i don't think ...

11 years, 3 months ago (2009-09-01 00:17:09 UTC) #3

piman

11 years, 3 months ago (2009-09-01 00:20:32 UTC) #4

On Mon, Aug 31, 2009 at 5:17 PM, <evan@chromium.org> wrote:

> (on that test page from the bug see no memory leak, but i don't think i
> saw one before i made this change either.)


Ok, I'll give it a shot when this goes in.

Antoine


>
>
> http://codereview.chromium.org/180051
>

Expand Messages | Collapse Messages