Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2501)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.cc

Issue 18004004: Web MIDI: Implement icon image and bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: generated_resources.grd Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings.cc
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.cc b/chrome/browser/content_settings/tab_specific_content_settings.cc
index f16589e4c5eb415efad2a4ff71d7021fcdd360df..d8e4278417e13506dceadb12efe24a9828cb7368 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.cc
+++ b/chrome/browser/content_settings/tab_specific_content_settings.cc
@@ -502,17 +502,13 @@ void TabSpecificContentSettings::OnCameraAccessBlocked() {
void TabSpecificContentSettings::OnMIDISysExAccessed(
const GURL& requesting_origin) {
midi_usages_state_.OnPermissionSet(requesting_origin, true);
- // TODO(toyoshim): Bubble icon for MIDI is disabled for now.
- // http://crbug.com/257618
- // OnContentAllowed(CONTENT_SETTINGS_TYPE_MIDI_SYSEX);
+ OnContentAllowed(CONTENT_SETTINGS_TYPE_MIDI_SYSEX);
}
void TabSpecificContentSettings::OnMIDISysExAccessBlocked(
const GURL& requesting_origin) {
midi_usages_state_.OnPermissionSet(requesting_origin, false);
- // TODO(toyoshim): Bubble icon for MIDI is disabled for now.
- // http://crbug.com/257618
- // OnContentBlocked(CONTENT_SETTINGS_TYPE_MIDI_SYSEX, std::string());
+ OnContentBlocked(CONTENT_SETTINGS_TYPE_MIDI_SYSEX, std::string());
}
void TabSpecificContentSettings::ClearBlockedContentSettingsExceptForCookies() {

Powered by Google App Engine
This is Rietveld 408576698