Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: chrome/browser/ui/views/infobars/infobar_container_view.h

Issue 1800373002: [MD] replace infobar bottom solid line separator with a shadow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_container_view.h
diff --git a/chrome/browser/ui/views/infobars/infobar_container_view.h b/chrome/browser/ui/views/infobars/infobar_container_view.h
index c2e99601bf2b11ae7fb19ace87a6c8fc89a9aa5f..1dbf447ed072a552addd9a90768b4966f2986130 100644
--- a/chrome/browser/ui/views/infobars/infobar_container_view.h
+++ b/chrome/browser/ui/views/infobars/infobar_container_view.h
@@ -14,15 +14,13 @@
// The views-specific implementation of InfoBarContainer.
class InfoBarContainerView : public views::AccessiblePaneView,
- public infobars::InfoBarContainer,
- public views::ViewTargeterDelegate {
+ public infobars::InfoBarContainer {
public:
static const char kViewClassName[];
explicit InfoBarContainerView(Delegate* delegate);
~InfoBarContainerView() override;
- private:
// AccessiblePaneView:
gfx::Size GetPreferredSize() const override;
const char* GetClassName() const override;
@@ -34,9 +32,11 @@ class InfoBarContainerView : public views::AccessiblePaneView,
size_t position) override;
void PlatformSpecificRemoveInfoBar(infobars::InfoBar* infobar) override;
- // ViewTargeterDelegate:
- bool DoesIntersectRect(const View* target,
- const gfx::Rect& rect) const override;
+ private:
+ // This view draws the shadow over the web contents below the
+ // lowest infobar. A separate view with a layer is used so it can
+ // draw outside the bounds of |this|.
+ views::View* content_shadow_;
DISALLOW_COPY_AND_ASSIGN(InfoBarContainerView);
};
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | chrome/browser/ui/views/infobars/infobar_container_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698