Chromium Code Reviews
Help | Chromium Project | Sign in
(51)

Issue 180037: Port some of the base system to FreeBSD. Extracted from... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Ben Laurie (Chromium)
Modified:
5 years, 10 months ago
Reviewers:
pvalchev, wtc
CC:
chromium-reviews_googlegroups.com, John Grabowski, Pam (message me for reviews), brettw (plz ping after 24h), Evan Martin, tony
Visibility:
Public.

Description

[Replaced by http://codereview.chromium.org/183016 ] Port some of the base system to FreeBSD. Extracted from http://codereview.chromium.org/172032

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -22 lines) Patch
M base/base_paths.h View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_linux.cc View 1 chunk +8 lines, -2 lines 0 comments Download
MM base/native_library.h View 1 chunk +1 line, -1 line 0 comments Download
M base/platform_thread.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/port.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +4 lines, -1 line 0 comments Download
M base/sys_info_posix.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M base/third_party/nspr/prcpucfg.h View 1 chunk +2 lines, -0 lines 0 comments Download
A base/third_party/nspr/prcpucfg_freebsd.h View 1 chunk +337 lines, -0 lines 0 comments Download
M base/third_party/nspr/prtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/time_posix.cc View 1 chunk +4 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 6 (0 generated)
wtc
Still LGTM. http://codereview.chromium.org/180037/diff/1/6 File base/process_util.h (right): http://codereview.chromium.org/180037/diff/1/6#newcode17 Line 17: // FIXME(benl): this surely can't be ...
7 years, 7 months ago (2009-08-29 23:37:54 UTC) #1
Ben Laurie (Chromium)
http://codereview.chromium.org/180037/diff/1/6 File base/process_util.h (right): http://codereview.chromium.org/180037/diff/1/6#newcode17 Line 17: // FIXME(benl): this surely can't be needed, since ...
7 years, 7 months ago (2009-08-30 04:43:45 UTC) #2
pvalchev
Nice! So I had started a very similar patch for OpenBSD: http://codereview.chromium.org/118469 But I got ...
7 years, 6 months ago (2009-09-03 23:09:07 UTC) #3
brettw (plz ping after 24h)
What about #if defined(OS_POSIX) && !defines(OS_LINUX) ? On Thu, Sep 3, 2009 at 4:08 PM, ...
7 years, 6 months ago (2009-09-04 00:02:29 UTC) #4
Ben Laurie (Chromium)
On Fri, Sep 4, 2009 at 1:02 AM, Brett Wilson<brettw@chromium.org> wrote: > What about > ...
7 years, 6 months ago (2009-09-04 10:04:14 UTC) #5
Ben Laurie (Chromium)
7 years, 6 months ago (2009-09-04 10:07:08 UTC) #6
On Fri, Sep 4, 2009 at 12:09 AM, <pvalchev@gmail.com> wrote:
> Nice!
>
> So I had started a very similar patch for OpenBSD:
> http://codereview.chromium.org/118469
>
> But I got really busy shortly after and went on vacation, I'd like to
> resume & merge my patch too. The reason I didn't finish it is because I
> wanted to clean it up and make a OS_BSD define like discussed in that
> patch with tony@, matching all of the BSD's. Any chance we can do this?
> I see you are adding OS_FREEBSD || OS_LINUX one-offs everywhere and the
> same will have to be repeated for all of the BSD's... it would be nice
> to make this cleaner.

Sure, I'd be happy to go down this route. Presumably you'd still want
there to be an OS_FREEBSD and OS_OPENBSD as well, for the, presumably
few, places where they differ?

> (Several of my smaller patches that fixed linux-isms were already
> submitted and benefit everyone)
>
>
> http://codereview.chromium.org/180037
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46