Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: media/base/media_log.cc

Issue 1800353002: Reduce MediaLog spam and add a note about unsupported statuses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Names. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/media_log.h ('k') | media/filters/ffmpeg_demuxer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/media_log.h" 5 #include "media/base/media_log.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/atomic_sequence_num.h" 9 #include "base/atomic_sequence_num.h"
10 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 AddEvent(std::move(event)); 238 AddEvent(std::move(event));
239 } 239 }
240 240
241 void MediaLog::SetStringProperty( 241 void MediaLog::SetStringProperty(
242 const std::string& key, const std::string& value) { 242 const std::string& key, const std::string& value) {
243 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE)); 243 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
244 event->params.SetString(key, value); 244 event->params.SetString(key, value);
245 AddEvent(std::move(event)); 245 AddEvent(std::move(event));
246 } 246 }
247 247
248 void MediaLog::SetIntegerProperty(
249 const std::string& key, int value) {
250 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
251 event->params.SetInteger(key, value);
252 AddEvent(std::move(event));
253 }
254
255 void MediaLog::SetDoubleProperty( 248 void MediaLog::SetDoubleProperty(
256 const std::string& key, double value) { 249 const std::string& key, double value) {
257 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE)); 250 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
258 event->params.SetDouble(key, value); 251 event->params.SetDouble(key, value);
259 AddEvent(std::move(event)); 252 AddEvent(std::move(event));
260 } 253 }
261 254
262 void MediaLog::SetBooleanProperty( 255 void MediaLog::SetBooleanProperty(
263 const std::string& key, bool value) { 256 const std::string& key, bool value) {
264 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE)); 257 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
265 event->params.SetBoolean(key, value); 258 event->params.SetBoolean(key, value);
266 AddEvent(std::move(event)); 259 AddEvent(std::move(event));
267 } 260 }
268 261
269 void MediaLog::SetTimeProperty(
270 const std::string& key, base::TimeDelta value) {
271 scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
272 if (value.is_max())
273 event->params.SetString(key, "unknown");
274 else
275 event->params.SetDouble(key, value.InSecondsF());
276 AddEvent(std::move(event));
277 }
278
279 LogHelper::LogHelper(MediaLog::MediaLogLevel level, 262 LogHelper::LogHelper(MediaLog::MediaLogLevel level,
280 const scoped_refptr<MediaLog>& media_log) 263 const scoped_refptr<MediaLog>& media_log)
281 : level_(level), media_log_(media_log) { 264 : level_(level), media_log_(media_log) {
282 DCHECK(media_log_.get()); 265 DCHECK(media_log_.get());
283 } 266 }
284 267
285 LogHelper::~LogHelper() { 268 LogHelper::~LogHelper() {
286 media_log_->AddLogEvent(level_, stream_.str()); 269 media_log_->AddLogEvent(level_, stream_.str());
287 } 270 }
288 271
289 } //namespace media 272 } //namespace media
OLDNEW
« no previous file with comments | « media/base/media_log.h ('k') | media/filters/ffmpeg_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698