Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 180035: Remove another swath of long passing Mac layout tests from test_expectations (Closed)

Created:
11 years, 3 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)
Visibility:
Public.

Description

Remove another swath of long passing Mac layout tests from test_expectations. BUG=10384 TEST=Covered by layout tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
TBR=ojan
11 years, 3 months ago (2009-08-29 02:21:59 UTC) #1
ojan
11 years, 3 months ago (2009-08-31 03:52:37 UTC) #2
LGTM! Thanks for doing this.

On Fri, Aug 28, 2009 at 7:21 PM, <paul@chromium.org> wrote:

> Reviewers: ojan,
>
> Message:
> TBR=ojan
>
> Description:
> Remove another swath of long passing Mac layout tests from
> test_expectations.
>
> BUG=10384
> TEST=Covered by layout tests.
>
>
> Please review this at http://codereview.chromium.org/180035
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 24844)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -1542,32 +1542,12 @@
>  // the file, but they were left there as the comments in those areas are
> valid.)
>  BUG10384 MAC :
> LayoutTests/animations/animation-end-event-destroy-renderer.html = TIMEOUT
> PASS
>  BUG10384 MAC :
> LayoutTests/fast/images/animated-background-image-crash.html = TIMEOUT PASS
> -BUG10384 MAC : LayoutTests/fast/css/background-shorthand-invalid-url.html
> = CRASH PASS
> -BUG10384 MAC : LayoutTests/fast/dom/Window/window-early-properties.html =
> CRASH TIMEOUT PASS
>  BUG10674 MAC : chrome/http/tests/misc/set-window-opener-to-null.html =
> PASS TIMEOUT FAIL
>  BUG10384 MAC : LayoutTests/fast/dom/Window/new-window-opener.html = CRASH
> TIMEOUT FAIL
>  BUG10384 MAC : LayoutTests/fast/forms/focus2.html = CRASH FAIL
> -BUG10384 MAC : LayoutTests/fast/borders/svg-as-border-image-2.html = CRASH
> PASS
> -BUG10384 MAC : LayoutTests/fast/canvas/pattern-with-transform.html = CRASH
> FAIL PASS
> -BUG10384 MAC : LayoutTests/fast/canvas/pointInPath.html = CRASH PASS
> -BUG10384 MAC :
> LayoutTests/fast/dom/Window/element-constructors-on-window.html = CRASH FAIL
> PASS
> -BUG10384 MAC : LayoutTests/fast/loader/charset-parse.html = CRASH FAIL
> PASS
> -BUG10384 MAC : LayoutTests/fast/borders/border-image-omit-right-slice.html
> = CRASH PASS
> -BUG10384 MAC : LayoutTests/fast/borders/border-image-01.html = CRASH PASS
> -BUG10384 MAC : LayoutTests/fast/canvas/linearGradient-infinite-values.html
> = CRASH PASS
> -BUG10384 MAC : LayoutTests/fast/css/acid2-pixel.html = CRASH PASS
> -BUG10384 MAC : LayoutTests/fast/canvas/gradient-with-clip.html = CRASH
> PASS
>  BUG10384 MAC LINUX : LayoutTests/fast/css/acid2.html = CRASH PASS
>  BUG10384 MAC : LayoutTests/fast/dom/HTMLObjectElement/object-as-frame.html
> = TIMEOUT FAIL PASS
>  BUG10384 DEBUG MAC :
> LayoutTests/editing/selection/drag-to-contenteditable-iframe.html = FAIL
> PASS
> -// These next few passes like 1 in 20 times, but it could be from
> corruption
> -// from previous tests that is causing the problems.
> -BUG10384 MAC : LayoutTests/http/tests/misc/xhtml.php = CRASH TIMEOUT FAIL
> PASS
> -BUG10384 MAC : LayoutTests/fast/dom/Window/console-functions.html = CRASH
> FAIL PASS
> -BUG10384 MAC :
> LayoutTests/http/tests/security/originHeader/origin-header-for-get.html =
> CRASH TIMEOUT FAIL PASS
> -BUG10384 MAC :
> LayoutTests/http/tests/security/aboutBlank/security-context-with-base-tag.html
> = CRASH FAIL PASS
> -BUG10384 MAC :
> LayoutTests/http/tests/security/host-compare-case-insensitive.html = CRASH
> FAIL PASS
> -BUG10384 MAC :
> LayoutTests/fast/dom/Window/window-open-self-from-other-frame.html = CRASH
> FAIL PASS
>
>  // -----------------------------------------------------------------
>  // END MAC PORT TESTS
>
>
>

Powered by Google App Engine
This is Rietveld 408576698