Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1800343002: Enable GN check for gpu and rlz (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
jschuh, piman
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org, dglazkov+blink, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable GN check for gpu and rlz Rlz already passed on Windows. GPU had a bunch of errors which are fixed here by adding the necessary dependencies and in a few cases removing unnecessary headers. gpu_memory_buffer_manager.h included stuff from ui/gfx but adding a dependency on //ui/gfx pulls Skia into the NaCl IRT (and mesa into Android) and everything goes badly. The GPU memory buffer stuff turns out to be separable from gfx so I created a new target for this. The same is true for ui/gfx/native_widget_types.h (this is just some enums in a .h file) so I made a separate target for this as well. In support of the Skia-in-NaCl problem, I added an assert_no_deps annotation on the NaCl IRT so people will get an error if they accidentally add this Skia dependency (this has come up before, it's easy to add a //ui/gfx dependency in the wrong place). It also fixes the Skia build in NaCl by updating the condition for extra warning to match build config. Without this update, the assert_no_deps won't be reached before an error running the skia build file, which won't make any sense in the context of addnig a random dependency. Minor cleanup of the use_libpci conditionals that was exposed by this (the define that controlled the header didn't exactly match the corresponding dependencies). CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel TBR=jschuh (gpu/ipc build changes) Committed: https://crrev.com/09039c14ad6710587d13e64e3ddf8cad1d292347 Cr-Commit-Position: refs/heads/master@{#381881}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Circular deps #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -33 lines) Patch
M .gn View 1 2 chunks +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 2 3 4 chunks +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/BUILD.gn View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 2 3 2 chunks +12 lines, -9 lines 0 comments Download
M gpu/skia_bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 5 8 chunks +66 lines, -13 lines 0 comments Download
M ui/gfx/native_widget_types.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 40 (22 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800343002/20001
4 years, 9 months ago (2016-03-16 00:12:19 UTC) #5
brettw
Please check the GPU dependencies carefully; I don't know what is allowed to depend on ...
4 years, 9 months ago (2016-03-16 00:12:26 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/36506) cast_shell_linux on ...
4 years, 9 months ago (2016-03-16 00:16:56 UTC) #8
piman
LGTM, this looks right. Thanks!
4 years, 9 months ago (2016-03-17 00:20:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800343002/40001
4 years, 9 months ago (2016-03-17 17:55:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/37404)
4 years, 9 months ago (2016-03-17 18:00:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800343002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800343002/80001
4 years, 9 months ago (2016-03-17 19:40:06 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/81980)
4 years, 9 months ago (2016-03-17 19:44:32 UTC) #21
brettw
Justing: gpu/ipc
4 years, 9 months ago (2016-03-17 19:49:56 UTC) #24
jschuh
lgtm for ipc: mechanical change
4 years, 9 months ago (2016-03-17 19:51:51 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800343002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800343002/100001
4 years, 9 months ago (2016-03-17 20:22:55 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/190642)
4 years, 9 months ago (2016-03-17 23:56:27 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800343002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800343002/100001
4 years, 9 months ago (2016-03-18 01:10:45 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-18 03:22:55 UTC) #35
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/09039c14ad6710587d13e64e3ddf8cad1d292347 Cr-Commit-Position: refs/heads/master@{#381881}
4 years, 9 months ago (2016-03-18 03:24:12 UTC) #37
oetuaho-nv
On 2016/03/18 03:24:12, commit-bot: I haz the power wrote: > Patchset 6 (id:??) landed as ...
4 years, 9 months ago (2016-03-21 09:32:41 UTC) #38
brettw
Will look at the GPU issue.
4 years, 9 months ago (2016-03-21 20:48:16 UTC) #39
brettw
4 years, 9 months ago (2016-03-21 21:45:54 UTC) #40
Message was sent while issue was closed.
https://codereview.chromium.org/1818143003/

Powered by Google App Engine
This is Rietveld 408576698