Keep multipart images in m_nonBlockingLoaders after first part loaded

third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2007 Graham Dennis (graham.dennis@gmail.com)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 111 matching lines @@
     RELEASE_ASSERT(m_state == ConnectionStateReceivedResponse);
     m_fetcher->didDownloadData(m_resource.get(), length, encodedDataLength);
     if (m_state == ConnectionStateReleased)
         return;
     m_resource->didDownloadData(length);
 }
 
 void ResourceLoader::didFinishLoadingOnePart(double finishTime, int64_t encodedDataLength)
 {
     ASSERT(m_state != ConnectionStateReleased);
     if (!isFinishing()) {

[yhirano, 2016/03/16 02:17:33]

[optional] It might be good to reorder clauses: I'd prefer "if (A) X else Y" to
"if (!A) Y else X".

[hiroshige, 2016/03/16 21:18:43]

Done.

         // When loading a multipart resource, make the loader non-block when
         // finishing loading the first part.
-        m_fetcher->subresourceLoaderFinishedLoadingOnePart(this);
+        m_fetcher->moveResourceLoaderToNonBlocking(this);
+
+        m_fetcher->didLoadResource(m_resource.get());
+        if (m_state == ConnectionStateReleased)
+            return;
+    } else {
+        m_fetcher->removeResourceLoader(this);
     }
 
-    if (m_state == ConnectionStateReleased)
-        return;
-
     if (m_notifiedLoadComplete)
         return;
     m_notifiedLoadComplete = true;
     m_fetcher->didFinishLoading(m_resource.get(), finishTime, encodedDataLength);
 }
 
 void ResourceLoader::didChangePriority(ResourceLoadPriority loadPriority, int intraPriorityValue)
 {
     ASSERT(m_state != ConnectionStateReleased);
     if (m_loader)
@@ skipping 255 matching lines @@
     // empty buffer is a noop in most cases, but is destructive in the case of
     // a 304, where it will overwrite the cached data we should be reusing.
     if (dataOut.size()) {
         m_fetcher->didReceiveData(m_resource.get(), dataOut.data(), dataOut.size(), encodedDataLength);
         m_resource->setResourceBuffer(dataOut);
     }
     didFinishLoading(0, monotonicallyIncreasingTime(), encodedDataLength);
 }
 
 } // namespace blink