Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/installer/setup/install.h

Issue 1800303006: Fix the path of shortcuts with an icon in the current install dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix buildbot error Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file contains the specification of setup main functions. 5 // This file contains the specification of setup main functions.
6 6
7 #ifndef CHROME_INSTALLER_SETUP_INSTALL_H_ 7 #ifndef CHROME_INSTALLER_SETUP_INSTALL_H_
8 #define CHROME_INSTALLER_SETUP_INSTALL_H_ 8 #define CHROME_INSTALLER_SETUP_INSTALL_H_
9 9
10 #include <vector> 10 #include <vector>
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 enum InstallShortcutLevel { 44 enum InstallShortcutLevel {
45 // Install shortcuts for the current user only. 45 // Install shortcuts for the current user only.
46 CURRENT_USER, 46 CURRENT_USER,
47 // Install global shortcuts visible to all users. Note: the Quick Launch 47 // Install global shortcuts visible to all users. Note: the Quick Launch
48 // and taskbar pin shortcuts are still installed per-user (as they have no 48 // and taskbar pin shortcuts are still installed per-user (as they have no
49 // all-users version). 49 // all-users version).
50 ALL_USERS, 50 ALL_USERS,
51 }; 51 };
52 52
53 // Sets |new_target_path| as the new target path of all shortcuts in the 53 // Sets |new_target_path| as the new target path of all shortcuts in the
54 // location specified by |shortcut_location| and |dist| which point to a file: 54 // location specified by |shortcut_location| and |dist| which either:
55 // - In |old_target_dir| or one of its subdirectories, and, 55 // - Point to a file rooted at |old_target_dir| whose name ends in
56 // - Whose path ends with |old_target_path_suffix|. 56 // |old_target_name_suffix|, or,
57 // - Have an icon rooted at |old_target_dir|.
57 void UpdatePerUserShortcutsInLocation( 58 void UpdatePerUserShortcutsInLocation(
58 const ShellUtil::ShortcutLocation shortcut_location, 59 const ShellUtil::ShortcutLocation shortcut_location,
59 BrowserDistribution* dist, 60 BrowserDistribution* dist,
60 const base::FilePath& old_target_dir, 61 const base::FilePath& old_target_dir,
61 const base::FilePath& old_target_path_suffix, 62 const base::FilePath& old_target_name_suffix,
62 const base::FilePath& new_target_path); 63 const base::FilePath& new_target_path);
63 64
64 // Escape |att_value| as per the XML AttValue production 65 // Escape |att_value| as per the XML AttValue production
65 // (http://www.w3.org/TR/2008/REC-xml-20081126/#NT-AttValue) for a value in 66 // (http://www.w3.org/TR/2008/REC-xml-20081126/#NT-AttValue) for a value in
66 // single quotes. 67 // single quotes.
67 void EscapeXmlAttributeValueInSingleQuotes(base::string16* att_value); 68 void EscapeXmlAttributeValueInSingleQuotes(base::string16* att_value);
68 69
69 // Creates VisualElementsManifest.xml beside chrome.exe in |src_path| if 70 // Creates VisualElementsManifest.xml beside chrome.exe in |src_path| if
70 // |src_path|\VisualElements exists. 71 // |src_path|\VisualElements exists.
71 // Returns true unless the manifest is supposed to be created, but fails to be. 72 // Returns true unless the manifest is supposed to be created, but fails to be.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 // Shortcut creation is skipped if the First Run beacon is present (unless 143 // Shortcut creation is skipped if the First Run beacon is present (unless
143 // |force| is set to true). 144 // |force| is set to true).
144 // |chrome| The installed product (must be a browser). 145 // |chrome| The installed product (must be a browser).
145 void HandleActiveSetupForBrowser(const base::FilePath& installation_root, 146 void HandleActiveSetupForBrowser(const base::FilePath& installation_root,
146 const Product& chrome, 147 const Product& chrome,
147 bool force); 148 bool force);
148 149
149 } // namespace installer 150 } // namespace installer
150 151
151 #endif // CHROME_INSTALLER_SETUP_INSTALL_H_ 152 #endif // CHROME_INSTALLER_SETUP_INSTALL_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698