Issue 1800303003: [Merge to M50] service worker: Fix valgrind errors on unit_tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1800303003: [Merge to M50] service worker: Fix valgrind errors on unit_tests (Closed)

Created:
4 years, 9 months ago by falken

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[Merge to M50] service worker: Fix valgrind errors on unit_tests Followup to https://codereview.chromium.org/1771283002/ We must clear request_context_getter_ on the IO thread or the valgrind bots cry. Also, call RemoveObserver in ShutdownOnIO in case OnContextIsShuttingDown is never called, as is the case on content_shell. BUG=587621, 593913 Review URL: https://codereview.chromium.org/1779353003 Cr-Commit-Position: refs/heads/master@{#380924} (cherry picked from commit 275701504450e46612ac5bc67c32a71838b6fdad) Committed: https://chromium.googlesource.com/chromium/src/+/6441fc81dd291d64e6be173e614fab176a1488b0

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	content/browser/service_worker/service_worker_context_wrapper.cc	View		3 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

falken

4 years, 9 months ago (2016-03-16 01:28:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6441fc81dd291d64e6be173e614fab176a1488b0.