Message center re-organized

chrome/browser/ui/views/message_center/message_center_frame_view.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_MESSAGE_CENTER_MESSAGE_CENTER_FRAME_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_MESSAGE_CENTER_MESSAGE_CENTER_FRAME_VIEW_H_
+
+#include "ui/views/window/non_client_view.h"
+
+namespace views {
+class Label;
+class LabelButton;
+class BubbleBorder;
+}
+
+namespace message_center {
+
+// The non-client frame view of the message center widget.
+class MessageCenterFrameView : public views::NonClientFrameView {
+ public:
+  explicit MessageCenterFrameView();
+  virtual ~MessageCenterFrameView();
+
+  // NonClientFrameView overrides:
+  virtual gfx::Rect GetBoundsForClientView() const OVERRIDE;
+  virtual gfx::Rect GetWindowBoundsForClientBounds(
+      const gfx::Rect& client_bounds) const OVERRIDE;
+  virtual int NonClientHitTest(const gfx::Point& point) OVERRIDE;
+  virtual void GetWindowMask(const gfx::Size& size, gfx::Path* window_mask)
+      OVERRIDE {}

[dewittj, 2013/07/15 18:38:58]

I believe that we prefer to put the definitions of virtual overrides
out-of-line, in the cc file.  See
http://www.chromium.org/developers/coding-style, section "Inline functions"

[sidharthms, 2013/07/15 23:16:37]

Done.

+  virtual void ResetWindowControls() OVERRIDE {}
+  virtual void UpdateWindowIcon() OVERRIDE {}
+  virtual void UpdateWindowTitle() OVERRIDE {}
+
+  // View overrides:
+  virtual gfx::Insets GetInsets() const OVERRIDE;
+  virtual const char* GetClassName() const OVERRIDE;
+
+  static gfx::Insets GetBorderInsets();

[dewittj, 2013/07/15 18:38:58]

Comment here please.  Why is this static?  Can this just return the result of
border->GetInsets()?

[sidharthms, 2013/07/15 23:16:37]

Done. Actually removed.

On 2013/07/15 18:38:58, dewittj wrote:

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MessageCenterFrameView);
+};
+
+}  // namespace message_center
+
+#endif  // CHROME_BROWSER_UI_VIEWS_MESSAGE_CENTER_MESSAGE_CENTER_FRAME_VIEW_H_