Message center re-organized

chrome/browser/ui/views/message_center/message_center_frame_view.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/message_center/message_center_frame_view.h"
+
+#include "ui/base/hit_test.h"
+#include "ui/message_center/message_center_style.h"
+#include "ui/views/shadow_border.h"
+#include "ui/views/widget/widget.h"
+
+namespace {
+
+const int kBorderWidth = 1;
+const int kShadowBlur = 8;
+
+}  // namepspace
+
+namespace message_center {
+
+MessageCenterFrameView::MessageCenterFrameView() {
+#if defined(OS_WIN)

[dewittj, 2013/07/16 18:24:01]

I'd prefer if the condition were opposite, so that the default is to have a
shadowborder, and the exception on Linux is to have a solid one.

[sidharthms, 2013/07/16 21:31:23]

Done.

+  set_border(new views::ShadowBorder(kShadowBlur,
+                                     message_center::kMessageCenterShadowColor,
+                                     0,    // Vertical offset
+                                     0));  // Horizontal offset
+#else
+  set_border(views::Border::CreateSolidBorder(
+      kBorderWidth, message_center::kMessageCenterBorderColor));
+#endif
+}
+
+MessageCenterFrameView::~MessageCenterFrameView() {}
+
+gfx::Rect MessageCenterFrameView::GetBoundsForClientView() const {
+  gfx::Rect client_bounds = GetLocalBounds();
+  client_bounds.Inset(GetInsets());
+  return client_bounds;
+}
+
+gfx::Rect MessageCenterFrameView::GetWindowBoundsForClientBounds(
+    const gfx::Rect& client_bounds) const {
+  gfx::Rect window_bounds = client_bounds;
+  window_bounds.Inset(GetInsets());
+  return window_bounds;
+}
+
+int MessageCenterFrameView::NonClientHitTest(const gfx::Point& point) {
+  gfx::Rect frame_bounds = bounds();
+  frame_bounds.Inset(GetInsets());
+  if (!frame_bounds.Contains(point))
+    return HTNOWHERE;
+
+  return GetWidget()->client_view()->NonClientHitTest(point);
+}
+
+void MessageCenterFrameView::GetWindowMask(const gfx::Size& size,
+                                           gfx::Path* window_mask) {}

[dewittj, 2013/07/16 18:24:01]

Make this match the style of the others, put the } on the next line.

[sidharthms, 2013/07/16 21:31:23]

Done. Missed that one. cl-format always puts empty braces this way
unfortunately.

+
+void MessageCenterFrameView::ResetWindowControls() {
+}
+
+void MessageCenterFrameView::UpdateWindowIcon() {
+}
+
+void MessageCenterFrameView::UpdateWindowTitle() {
+}
+
+gfx::Insets MessageCenterFrameView::GetInsets() const {
+  return border()->GetInsets();
+}
+
+const char* MessageCenterFrameView::GetClassName() const {
+  return "MessageCenterFrameView";
+}
+
+}  // namespace message_center