Message center re-organized

chrome/browser/notifications/message_center_settings_controller.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/message_center_settings_controller.h"
 
 #include <algorithm>
 
 #include "base/i18n/string_compare.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 57 matching lines @@
 
 void MessageCenterSettingsController::RemoveObserver(
     message_center::NotifierSettingsObserver* observer) {
   observers_.RemoveObserver(observer);
 }
 
 void MessageCenterSettingsController::GetNotifierList(
     std::vector<Notifier*>* notifiers) {
   DCHECK(notifiers);
   // TODO(mukai): Fix this for multi-profile.
-  Profile* profile = ProfileManager::GetDefaultProfile();
+  // Temporarily use the last used profile to prevent chrome from crashing when
+  // the default profile is not loaded.

[dewittj, 2013/06/28 01:13:18]

I suspect you should actually use GetLastUsedProfileAllowedByPolicy.

Actually, though, we might want to merge this into m29 separately.  Could you
make a separate patch including just this change?

[sidharthms, 2013/07/02 18:09:51]

Done.

+  Profile* profile = ProfileManager::GetLastUsedProfile();
   DesktopNotificationService* notification_service =
       DesktopNotificationServiceFactory::GetForProfile(profile);
 
   UErrorCode error;
   scoped_ptr<icu::Collator> collator(icu::Collator::createInstance(error));
   scoped_ptr<NotifierComparator> comparator;
   if (!U_FAILURE(error))
     comparator.reset(new NotifierComparator(collator.get()));
 
   ExtensionService* extension_service = profile->GetExtensionService();
@@ skipping 144 matching lines @@
                     UpdateFavicon(url, favicon_result.image));
 }
 
 
 void MessageCenterSettingsController::SetAppImage(const std::string& id,
                                                   const gfx::ImageSkia& image) {
   FOR_EACH_OBSERVER(message_center::NotifierSettingsObserver,
                     observers_,
                     UpdateIconImage(id, gfx::Image(image)));
 }