Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 1800233003: [crankshaft] Generate lazy bailout point for HProlog instruction only when it is necessary. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Generate lazy bailout point for HProlog instruction only when it is necessary. This fix removes unnecessary nops from function prolog and seems to recover performance regression on some of SunSpider benchmarks. TBR=bmeurer@chromium.org BUG=chromium:531369 LOG=N Committed: https://crrev.com/b82e10d39d04d769794223ffea4b8c1bd29be1c5 Cr-Commit-Position: refs/heads/master@{#34810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -18 lines) Patch
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800233003/1
4 years, 9 months ago (2016-03-15 18:41:31 UTC) #2
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-15 18:58:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 19:01:22 UTC) #6
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-16 09:30:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800233003/1
4 years, 9 months ago (2016-03-16 11:12:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12424)
4 years, 9 months ago (2016-03-16 11:16:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800233003/1
4 years, 9 months ago (2016-03-16 11:17:13 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 11:19:14 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 11:21:01 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b82e10d39d04d769794223ffea4b8c1bd29be1c5
Cr-Commit-Position: refs/heads/master@{#34810}

Powered by Google App Engine
This is Rietveld 408576698