Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8246)

Unified Diff: chrome/plugin/webplugin_delegate_stub.cc

Issue 180019: linux: disable querying the page window for windowless plugins (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/webplugin_delegate_stub.cc
diff --git a/chrome/plugin/webplugin_delegate_stub.cc b/chrome/plugin/webplugin_delegate_stub.cc
index a8a652fe8780cf18c1e136e05bbbb3151c1d3890..97a0adaeac408ba378e34c472d6f2b3fc38b5029 100644
--- a/chrome/plugin/webplugin_delegate_stub.cc
+++ b/chrome/plugin/webplugin_delegate_stub.cc
@@ -146,8 +146,12 @@ void WebPluginDelegateStub::OnInit(const PluginMsg_Init_Params& params,
#if defined(OS_WIN)
parent = gfx::NativeViewFromId(params.containing_window);
#elif defined(OS_LINUX)
- PluginThread::current()->Send(new PluginProcessHostMsg_MapNativeViewId(
- params.containing_window, &parent));
+ // This code is disabled, See issue 17110.
+ // The problem is that the XID can change at arbitrary times (e.g. when the
+ // tab is detached then reattached), so we need to be able to track these
+ // changes, and let the PluginInstance know.
+ // PluginThread::current()->Send(new PluginProcessHostMsg_MapNativeViewId(
+ // params.containing_window, &parent));
#endif
delegate_ = WebPluginDelegate::Create(path, mime_type_, parent);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698