Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: chrome/test/data/extensions/samples/subscribe_page_action/background.html

Issue 180016: Extension API Renaming/Consistency changes (Closed)
Patch Set: render docs Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/samples/subscribe_page_action/background.html
diff --git a/chrome/test/data/extensions/samples/subscribe_page_action/background.html b/chrome/test/data/extensions/samples/subscribe_page_action/background.html
index 4d14440ba9d112990555bef141313888f49ec283..e77d2e436fd8d7fffe0fa7440867e41eba1da2de 100644
--- a/chrome/test/data/extensions/samples/subscribe_page_action/background.html
+++ b/chrome/test/data/extensions/samples/subscribe_page_action/background.html
@@ -33,9 +33,10 @@
});
// Chrome will call into us when the user clicks on the icon in the OmniBox.
- chrome.pageActions["RssPageAction"].addListener(function(reply) {
+ chrome.pageActions["RssPageAction"].addListener(function(pageActionId,
+ pageActionInfo) {
chrome.windows.getCurrent(function(window) {
- chrome.tabs.get(reply.data.tabId, function(tab) {
+ chrome.tabs.get(pageActionInfo.tabId, function(tab) {
// We need to know if we are the active window, because the tab may
// have moved to another window and we don't want to execute this
// action multiple times.
@@ -43,7 +44,7 @@
// Create a new tab showing the subscription page with the right
// feed URL.
chrome.tabs.create({url: "subscribe.html?" +
- feedData[reply.data.tabId].feedUrl,
+ feedData[pageActionInfo.tabId].feedUrl,
windowId: window.windowId});
}
});
« no previous file with comments | « chrome/test/data/extensions/samples/mole/mole.html ('k') | chrome/test/data/extensions/samples/tabs/tabs_api.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698