Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: chrome/renderer/resources/renderer_extension_bindings.js

Issue 180016: Extension API Renaming/Consistency changes (Closed)
Patch Set: render docs Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/renderer_extension_bindings.js
diff --git a/chrome/renderer/resources/renderer_extension_bindings.js b/chrome/renderer/resources/renderer_extension_bindings.js
index cf53de97af43202e98fb01ad26552785c751b132..6e9b387dc16f84c877f2ba443fc95f89fbe0a80d 100644
--- a/chrome/renderer/resources/renderer_extension_bindings.js
+++ b/chrome/renderer/resources/renderer_extension_bindings.js
@@ -16,7 +16,7 @@
var chrome = chrome || {};
(function () {
- native function OpenChannelToExtension(id);
+ native function OpenChannelToExtension(id, name);
native function CloseChannel(portId);
native function PortAddRef(portId);
native function PortRelease(portId);
@@ -115,11 +115,15 @@ var chrome = chrome || {};
// Opens a message channel to the extension. Returns a Port for
// message passing.
- chrome.Extension.prototype.connect = function(opt_name) {
- var portId = OpenChannelToExtension(this.id_, opt_name || "");
+ chrome.Extension.prototype.connect = function(connectInfo) {
+ var name = "";
+ if (connectInfo) {
+ name = connectInfo.name || name;
+ }
+ var portId = OpenChannelToExtension(this.id_, name);
if (portId == -1)
throw new Error("No such extension: '" + this.id_ + "'");
- return chromeHidden.Port.createPort(portId, opt_name);
+ return chromeHidden.Port.createPort(portId, name);
};
// Returns a resource URL that can be used to fetch a resource from this

Powered by Google App Engine
This is Rietveld 408576698