Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: components/test_runner/event_sender.cc

Issue 1800143002: Notify Blink about start of gesture scroll through a queued event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased, fixed input_router_imp_unittest Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/event_sender.cc
diff --git a/components/test_runner/event_sender.cc b/components/test_runner/event_sender.cc
index 393572482957e5cc3f4162a6fbb5fb366717c278..62faff47a5ee82fe22298f844a7060b270baf6f9 100644
--- a/components/test_runner/event_sender.cc
+++ b/components/test_runner/event_sender.cc
@@ -510,6 +510,8 @@ class EventSenderBindings : public gin::Wrappable<EventSenderBindings> {
void TouchMoveCausingScrollIfUncanceled();
void TouchCancel();
void TouchEnd();
+ void NotifyStartOfTouchScroll();
+ void NotifyEndOfTouchScroll();
tdresser 2016/03/30 19:19:01 This appears to never be defined...
mustaq 2016/03/30 20:21:05 Removed.
void LeapForward(int milliseconds);
double LastEventTimestamp();
void BeginDragWithFiles(const std::vector<std::string>& files);
@@ -631,10 +633,10 @@ EventSenderBindings::GetObjectTemplateBuilder(v8::Isolate* isolate) {
&EventSenderBindings::GestureScrollFirstPoint)
.SetMethod("touchStart", &EventSenderBindings::TouchStart)
.SetMethod("touchMove", &EventSenderBindings::TouchMove)
- .SetMethod("touchMoveCausingScrollIfUncanceled",
- &EventSenderBindings::TouchMoveCausingScrollIfUncanceled)
.SetMethod("touchCancel", &EventSenderBindings::TouchCancel)
.SetMethod("touchEnd", &EventSenderBindings::TouchEnd)
+ .SetMethod("notifyStartOfTouchScroll",
+ &EventSenderBindings::NotifyStartOfTouchScroll)
.SetMethod("leapForward", &EventSenderBindings::LeapForward)
.SetMethod("lastEventTimestamp", &EventSenderBindings::LastEventTimestamp)
.SetMethod("beginDragWithFiles", &EventSenderBindings::BeginDragWithFiles)
@@ -815,11 +817,6 @@ void EventSenderBindings::TouchMove() {
sender_->TouchMove();
}
-void EventSenderBindings::TouchMoveCausingScrollIfUncanceled() {
- if (sender_)
- sender_->TouchMoveCausingScrollIfUncanceled();
-}
-
void EventSenderBindings::TouchCancel() {
if (sender_)
sender_->TouchCancel();
@@ -830,6 +827,11 @@ void EventSenderBindings::TouchEnd() {
sender_->TouchEnd();
}
+void EventSenderBindings::NotifyStartOfTouchScroll() {
+ if (sender_)
+ sender_->NotifyStartOfTouchScroll();
+}
+
void EventSenderBindings::LeapForward(int milliseconds) {
if (sender_)
sender_->LeapForward(milliseconds);
@@ -1813,10 +1815,6 @@ void EventSender::TouchMove() {
SendCurrentTouchEvent(WebInputEvent::TouchMove, false);
}
-void EventSender::TouchMoveCausingScrollIfUncanceled() {
- SendCurrentTouchEvent(WebInputEvent::TouchMove, true);
-}
-
void EventSender::TouchCancel() {
SendCurrentTouchEvent(WebInputEvent::TouchCancel, false);
}
@@ -1825,6 +1823,12 @@ void EventSender::TouchEnd() {
SendCurrentTouchEvent(WebInputEvent::TouchEnd, false);
}
+void EventSender::NotifyStartOfTouchScroll() {
+ WebTouchEvent event;
+ event.type = WebInputEvent::TouchScrollStarted;
+ HandleInputEventOnViewOrPopup(event);
+}
+
void EventSender::LeapForward(int milliseconds) {
if (is_drag_mode_ && pressed_button_ == WebMouseEvent::ButtonLeft &&
!replaying_saved_events_) {

Powered by Google App Engine
This is Rietveld 408576698