Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointercancel.html

Issue 1800143002: Notify Blink about start of gesture scroll through a queued event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a few checks. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/input/render_widget_input_handler.cc ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointercancel-expected.txt » ('j') | third_party/WebKit/Source/core/events/PointerEventFactory.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <script src="../../../resources/js-test.js"></script> 2 <script src="../../../resources/js-test.js"></script>
3 <style> 3 <style>
4 div.test { 4 div.test {
5 margin: 10px; 5 margin: 10px;
6 width: 100px; 6 width: 100px;
7 height: 200px; 7 height: 200px;
8 overflow: scroll; 8 overflow: scroll;
9 border: solid 1px; 9 border: solid 1px;
10 float: left; 10 float: left;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 if (event.type == eventToPreventDefault) { 42 if (event.type == eventToPreventDefault) {
43 event.preventDefault(); 43 event.preventDefault();
44 preventDefaultMsg = ", prevented default"; 44 preventDefaultMsg = ", prevented default";
45 } 45 }
46 46
47 debug("Received " + event.type + idMsg + preventDefaultMsg); 47 debug("Received " + event.type + idMsg + preventDefaultMsg);
48 }); 48 });
49 }); 49 });
50 } 50 }
51 51
52 function testSingleDrag(uncanceledMoveCausesScroll) { 52 function testSingleDrag(notifyStartOfTouchScroll) {
53 var rect = document.getElementById("target").getBoundingClientRect(); 53 var rect = document.getElementById("target").getBoundingClientRect();
54 var x = rect.left + 50; 54 var x = rect.left + 50;
55 var y = rect.top + 50; 55 var y = rect.top + 50;
56 56
57 eventSender.addTouchPoint(x, y); 57 eventSender.addTouchPoint(x, y);
58 eventSender.touchStart(); 58 eventSender.touchStart();
59 59
60 eventSender.updateTouchPoint(0, x, y+50); 60 eventSender.updateTouchPoint(0, x, y+50);
61 eventSender.touchMove(); 61 eventSender.touchMove();
62 62
63 if (notifyStartOfTouchScroll)
64 eventSender.notifyStartOfTouchScroll();
65
63 eventSender.updateTouchPoint(0, x, y+100); 66 eventSender.updateTouchPoint(0, x, y+100);
64 if (uncanceledMoveCausesScroll) 67 eventSender.touchMove();
65 eventSender.touchMoveCausingScrollIfUncanceled();
66 else
67 eventSender.touchMove();
68 68
69 eventSender.updateTouchPoint(0, x, y+150); 69 eventSender.updateTouchPoint(0, x, y+150);
70 eventSender.touchMove(); 70 eventSender.touchMove();
71 71
72 eventSender.releaseTouchPoint(0); 72 eventSender.releaseTouchPoint(0);
73 eventSender.touchEnd(); 73 eventSender.touchEnd();
74 } 74 }
75 75
76 function testMultiDrag(uncanceledMoveCausesScroll) { 76 function testMultiDrag(notifyStartOfTouchScroll) {
77 var rect; 77 var rect;
78 78
79 rect = document.getElementById("target").getBoundingClientRect(); 79 rect = document.getElementById("target").getBoundingClientRect();
80 var x0 = rect.left + 30; 80 var x0 = rect.left + 30;
81 var x1 = rect.left + 50; 81 var x1 = rect.left + 50;
82 var x2 = rect.left + 70; 82 var x2 = rect.left + 70;
83 var x3 = rect.left + 55; 83 var x3 = rect.left + 55;
84 var y = rect.top + 50; 84 var y = rect.top + 50;
85 85
86 eventSender.addTouchPoint(x0, y); 86 eventSender.addTouchPoint(x0, y);
87 eventSender.addTouchPoint(x1, y); 87 eventSender.addTouchPoint(x1, y);
88 eventSender.addTouchPoint(x2, y); 88 eventSender.addTouchPoint(x2, y);
89 eventSender.touchStart(); 89 eventSender.touchStart();
90 90
91 y += 50; 91 y += 50;
92 eventSender.updateTouchPoint(0, x0, y); 92 eventSender.updateTouchPoint(0, x0, y);
93 eventSender.updateTouchPoint(1, x1, y); 93 eventSender.updateTouchPoint(1, x1, y);
94 eventSender.updateTouchPoint(2, x2, y); 94 eventSender.updateTouchPoint(2, x2, y);
95 eventSender.touchMove(); 95 eventSender.touchMove();
96 96
97 y += 50; 97 y += 50;
98 eventSender.updateTouchPoint(0, x0, y); 98 eventSender.updateTouchPoint(0, x0, y);
99 eventSender.updateTouchPoint(1, x1, y); 99 eventSender.updateTouchPoint(1, x1, y);
100 eventSender.updateTouchPoint(2, x2, y); 100 eventSender.updateTouchPoint(2, x2, y);
101 if (uncanceledMoveCausesScroll) 101 eventSender.touchMove();
102 eventSender.touchMoveCausingScrollIfUncanceled(); 102
103 else 103 if (notifyStartOfTouchScroll)
104 eventSender.touchMove(); 104 eventSender.notifyStartOfTouchScroll();
105 105
106 eventSender.addTouchPoint(x3, y); 106 eventSender.addTouchPoint(x3, y);
107 eventSender.touchStart(); 107 eventSender.touchStart();
108 108
109 y += 50; 109 y += 50;
110 eventSender.updateTouchPoint(0, x0, y); 110 eventSender.updateTouchPoint(0, x0, y);
111 eventSender.updateTouchPoint(1, x1, y); 111 eventSender.updateTouchPoint(1, x1, y);
112 eventSender.updateTouchPoint(2, x2, y); 112 eventSender.updateTouchPoint(2, x2, y);
113 eventSender.updateTouchPoint(3, x3, y); 113 eventSender.updateTouchPoint(3, x3, y);
114 eventSender.touchMove(); 114 eventSender.touchMove();
(...skipping 29 matching lines...) Expand all
144 144
145 eventSender.cancelTouchPoint(0); 145 eventSender.cancelTouchPoint(0);
146 eventSender.cancelTouchPoint(1); 146 eventSender.cancelTouchPoint(1);
147 eventSender.touchCancel(); 147 eventSender.touchCancel();
148 } 148 }
149 149
150 function runTests() { 150 function runTests() {
151 debug("--- single drag tests ---"); 151 debug("--- single drag tests ---");
152 debug(""); 152 debug("");
153 153
154 debug("-- preventDefault on none, without uncanceledMoveCausesScroll --"); 154 debug("-- preventDefault on none, without notifyStartOfTouchScroll --");
155 eventToPreventDefault = "-none-"; 155 eventToPreventDefault = "-none-";
156 testSingleDrag(false); 156 testSingleDrag(false);
157 debug(""); 157 debug("");
158 158
159 debug("-- preventDefault on pointermove, without uncanceledMoveCausesScroll -- "); 159 debug("-- preventDefault on pointermove, without notifyStartOfTouchScroll --") ;
160 eventToPreventDefault = "pointermove"; 160 eventToPreventDefault = "pointermove";
161 testSingleDrag(false); 161 testSingleDrag(false);
162 debug(""); 162 debug("");
163 163
164 debug("-- preventDefault on touchmove, without uncanceledMoveCausesScroll --") ; 164 debug("-- preventDefault on none, with notifyStartOfTouchScroll --");
165 eventToPreventDefault = "touchmove";
166 testSingleDrag(false);
167 debug("");
168
169 debug("-- preventDefault on none, with uncanceledMoveCausesScroll --");
170 eventToPreventDefault = "-none-"; 165 eventToPreventDefault = "-none-";
171 testSingleDrag(true); 166 testSingleDrag(true);
172 debug(""); 167 debug("");
173 168
174 debug("-- preventDefault on pointermove, with uncanceledMoveCausesScroll --"); 169 debug("-- preventDefault on pointermove, with notifyStartOfTouchScroll --");
175 eventToPreventDefault = "pointermove"; 170 eventToPreventDefault = "pointermove";
176 testSingleDrag(true); 171 testSingleDrag(true);
177 debug(""); 172 debug("");
178 173
179 debug("-- preventDefault on touchmove, with uncanceledMoveCausesScroll --");
180 eventToPreventDefault = "touchmove";
bokan 2016/04/12 22:42:45 Why do we no longer care about testing preventDefa
mustaq 2016/04/13 14:56:27 Quoting below the comment I made in patch#5 of thi
bokan 2016/04/13 22:59:48 Ah, ok, it was testing an implementation detail th
181 testSingleDrag(true);
182 debug("");
183
184 debug("--- multi drag tests ---"); 174 debug("--- multi drag tests ---");
185 debug(""); 175 debug("");
186 176
187 debug("-- preventDefault on none, without uncanceledMoveCausesScroll --"); 177 debug("-- preventDefault on none, without notifyStartOfTouchScroll --");
188 eventToPreventDefault = "-none-"; 178 eventToPreventDefault = "-none-";
189 testMultiDrag(false); 179 testMultiDrag(false);
190 debug(""); 180 debug("");
191 181
192 debug("-- preventDefault on none, with uncanceledMoveCausesScroll --"); 182 debug("-- preventDefault on none, with notifyStartOfTouchScroll --");
193 eventToPreventDefault = "-none-"; 183 eventToPreventDefault = "-none-";
194 testMultiDrag(true); 184 testMultiDrag(true);
195 debug(""); 185 debug("");
196 186
197 debug("--- multi cancel tests ---"); 187 debug("--- multi cancel tests ---");
198 debug(""); 188 debug("");
199 testMultiCancel(); 189 testMultiCancel();
200 debug(""); 190 debug("");
201 } 191 }
202 192
203 193
204 init(); 194 init();
205 if (window.eventSender) 195 if (window.eventSender)
206 runTests(); 196 runTests();
207 else 197 else
208 debug("This test requires eventSender"); 198 debug("This test requires eventSender");
209 199
210 </script> 200 </script>
OLDNEW
« no previous file with comments | « content/renderer/input/render_widget_input_handler.cc ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointercancel-expected.txt » ('j') | third_party/WebKit/Source/core/events/PointerEventFactory.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698