Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1800113002: Fix typo in comment: NavigationHandle::HasCommitted (Closed)

Created:
4 years, 9 months ago by vabr (Chromium)
Modified:
4 years, 9 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in comment: NavigationHandle::HasCommitted This is just a silly typo, but makes searching for the mentioned method hard. BUG=576287 Committed: https://crrev.com/d9092d3a3e0865e8c5b092f627eb80a9d26b4f80 Cr-Commit-Position: refs/heads/master@{#381506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/browser/web_contents_observer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
vabr (Chromium)
Hi Nick, PTAL, thanks! Vaclav
4 years, 9 months ago (2016-03-15 15:05:11 UTC) #2
ncarter (slow)
lgtm
4 years, 9 months ago (2016-03-16 17:29:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800113002/1
4 years, 9 months ago (2016-03-16 17:29:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 19:03:49 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 19:05:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9092d3a3e0865e8c5b092f627eb80a9d26b4f80
Cr-Commit-Position: refs/heads/master@{#381506}

Powered by Google App Engine
This is Rietveld 408576698