Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5666)

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 18001004: Remove Hangul IME with migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/preferences.cc
diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc
index 5a2eec73175e77d0867d2542b82d7093f0e69df2..53f2583b1336398b4236e5bf3526149395e975a0 100644
--- a/chrome/browser/chromeos/preferences.cc
+++ b/chrome/browser/chromeos/preferences.cc
@@ -766,9 +766,13 @@ void Preferences::NotifyPrefChanged(const std::string* pref_name) {
}
if (!pref_name ||
*pref_name == prefs::kLanguageHangulKeyboard) {
- SetLanguageConfigString(language_prefs::kHangulSectionName,
- language_prefs::kHangulKeyboardConfigName,
- hangul_keyboard_.GetValue());
+ std::vector<std::string> new_input_method_ids;
+ if (input_method_manager_->MigrateKoreanKeyboard(
+ hangul_keyboard_.GetValue(),
+ &new_input_method_ids)) {
+ preload_engines_.SetValue(JoinString(new_input_method_ids, ','));
+ hangul_keyboard_.SetValue("dummy_value_already_migrated");
+ }
}
if (!pref_name || *pref_name == prefs::kLanguageHangulHanjaBindingKeys) {
Shu Chen 2013/06/28 03:06:54 this is no change?
Seigo Nonaka 2013/06/28 03:28:51 Yes, above change is for migration. All configurat
satorux1 2013/07/01 03:33:45 Please file a bug and add the bug URL here.
Seigo Nonaka 2013/07/01 04:00:03 Done.
SetLanguageConfigString(language_prefs::kHangulSectionName,
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('k') | chromeos/ime/input_method_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698