Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1800073002: [Interpreter] Updates InlineTwice in test-run-inlining to match other tests. (Closed)

Created:
4 years, 9 months ago by mythria
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Updates InlineTwice in test-run-inlining to match other tests. Updates InlineTwice to declare a function and then return a function instead of using function expressions by wrapping a function with '(' and ')'. The earlier implementation would cause the function to compile immediately instead of lazy compile. Also updates cctest.status BUG=v8:4280, v8:4837, v8:4680 LOG=N Committed: https://crrev.com/c83836325113dca55a3c206d401730af3171853e Cr-Commit-Position: refs/heads/master@{#34790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800073002/1
4 years, 9 months ago (2016-03-15 12:37:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 12:59:09 UTC) #6
mythria
PTAL, Thanks, Mythri
4 years, 9 months ago (2016-03-15 13:08:58 UTC) #8
Michael Starzinger
LGTM. Thanks!
4 years, 9 months ago (2016-03-15 13:57:59 UTC) #9
rmcilroy
LGTM, thanks.
4 years, 9 months ago (2016-03-15 14:06:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800073002/1
4 years, 9 months ago (2016-03-15 14:25:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 14:27:44 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 14:29:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c83836325113dca55a3c206d401730af3171853e
Cr-Commit-Position: refs/heads/master@{#34790}

Powered by Google App Engine
This is Rietveld 408576698