Source/core/editing/InsertListCommand.cpp - Issue 180003007: Fixing crash in doApplyForSingleParagraph().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertListCommand.cpp

Issue 180003007: Fixing crash in doApplyForSingleParagraph(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing review comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/InsertListCommand.cpp

diff --git a/Source/core/editing/InsertListCommand.cpp b/Source/core/editing/InsertListCommand.cpp

index 15ea47e3d99d2463f155f9cea796339351bc8784..dbd83ec3123cc5a3b2e9096f2cd4a39076fab685 100644

--- a/Source/core/editing/InsertListCommand.cpp

+++ b/Source/core/editing/InsertListCommand.cpp

@@ -221,7 +221,7 @@ void InsertListCommand::doApplyForSingleParagraph(bool forceCreateList, const Qu

insertNodeBefore(newList, listNode);

Node* firstChildInList = enclosingListChild(VisiblePosition(firstPositionInNode(listNode.get())).deepEquivalent().deprecatedNode(), listNode.get());

- Node* outerBlock = firstChildInList->isBlockFlowElement() ? firstChildInList : listNode.get();

+ Node* outerBlock = firstChildInList ? (firstChildInList->isBlockFlowElement() ? firstChildInList : listNode.get()) : listNode.get();

Yuta Kitamura 2014/02/27 01:59:14 This can be simplified as: firstChildInList &&

arpitab_ 2014/02/27 05:10:07 Done.

moveParagraphWithClones(VisiblePosition(firstPositionInNode(listNode.get())), VisiblePosition(lastPositionInNode(listNode.get())), newList.get(), outerBlock);

« LayoutTests/editing/execCommand/crash-inserting-list.html ('K') | « LayoutTests/editing/execCommand/crash-inserting-list-expected.txt ('k') | no next file » | no next file with comments »