Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180003007: Fixing crash in doApplyForSingleParagraph(). (Closed)

Created:
6 years, 10 months ago by arpitab_
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fixing crash in doApplyForSingleParagraph(). enclosingListChild() method can return 0 but no null check is implemented at its calling location. Adding a null check for the same. Note that the corresponding bug mentions r163661 as being the cause for this crash. However the crash persists even after reverting r163661. BUG=345373 Test=editing/execCommand/crash-inserting-list.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167991

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing review comments #

Total comments: 8

Patch Set 3 : Addressing review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
A LayoutTests/editing/execCommand/crash-inserting-list.html View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/editing/execCommand/crash-inserting-list-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
arpitab_
6 years, 10 months ago (2014-02-26 07:18:55 UTC) #1
yoichio
https://codereview.chromium.org/180003007/diff/1/Source/core/editing/InsertListCommand.cpp File Source/core/editing/InsertListCommand.cpp (right): https://codereview.chromium.org/180003007/diff/1/Source/core/editing/InsertListCommand.cpp#newcode224 Source/core/editing/InsertListCommand.cpp:224: Node* outerBlock = firstChildInList ? firstChildInList->isBlockFlowElement() ? firstChildInList : ...
6 years, 10 months ago (2014-02-26 07:26:30 UTC) #2
arpitab_
Posted another patch after addressing the review comments. https://codereview.chromium.org/180003007/diff/1/Source/core/editing/InsertListCommand.cpp File Source/core/editing/InsertListCommand.cpp (right): https://codereview.chromium.org/180003007/diff/1/Source/core/editing/InsertListCommand.cpp#newcode224 Source/core/editing/InsertListCommand.cpp:224: Node* ...
6 years, 10 months ago (2014-02-26 08:08:59 UTC) #3
yoichio
lgtm
6 years, 10 months ago (2014-02-26 08:26:02 UTC) #4
arpitab_
The CQ bit was checked by a.bah@samsung.com
6 years, 10 months ago (2014-02-26 08:57:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/180003007/20001
6 years, 10 months ago (2014-02-26 08:57:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 09:21:26 UTC) #7
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=16752
6 years, 10 months ago (2014-02-26 09:21:26 UTC) #8
arpitab_
On 2014/02/26 09:21:26, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-26 12:40:01 UTC) #9
yosin_UTC9
+yutak@ for OWNERS review.
6 years, 10 months ago (2014-02-27 01:41:57 UTC) #10
Yuta Kitamura
https://codereview.chromium.org/180003007/diff/20001/LayoutTests/editing/execCommand/crash-inserting-list.html File LayoutTests/editing/execCommand/crash-inserting-list.html (right): https://codereview.chromium.org/180003007/diff/20001/LayoutTests/editing/execCommand/crash-inserting-list.html#newcode17 LayoutTests/editing/execCommand/crash-inserting-list.html:17: <script> <script> cannot be a direct child of <html>. ...
6 years, 10 months ago (2014-02-27 01:59:14 UTC) #11
arpitab_
https://codereview.chromium.org/180003007/diff/20001/LayoutTests/editing/execCommand/crash-inserting-list.html File LayoutTests/editing/execCommand/crash-inserting-list.html (right): https://codereview.chromium.org/180003007/diff/20001/LayoutTests/editing/execCommand/crash-inserting-list.html#newcode17 LayoutTests/editing/execCommand/crash-inserting-list.html:17: <script> On 2014/02/27 01:59:14, Yuta Kitamura wrote: > <script> ...
6 years, 9 months ago (2014-02-27 05:10:06 UTC) #12
Yuta Kitamura
lgtm
6 years, 9 months ago (2014-02-27 05:12:43 UTC) #13
arpitab_
The CQ bit was checked by a.bah@samsung.com
6 years, 9 months ago (2014-02-27 05:17:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/180003007/40001
6 years, 9 months ago (2014-02-27 05:18:10 UTC) #15
commit-bot: I haz the power
Change committed as 167991
6 years, 9 months ago (2014-02-27 07:50:20 UTC) #16
ojan
6 years, 9 months ago (2014-03-05 00:57:31 UTC) #17
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698