Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180003003: [NaCl SDK Docs] Fix README, cleanup Makefile, remove devsite stuff. (Closed)

Created:
6 years, 10 months ago by binji
Modified:
6 years, 10 months ago
Reviewers:
JF, Sam Clegg
CC:
chromium-reviews, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK Docs] Fix README, cleanup Makefile, remove devsite stuff. BUG=341480 R=jfb@chromium.org, sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253268

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Patch Set 3 : modified presubmit so I can dcommit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -250 lines) Patch
M native_client_sdk/src/doc/Makefile View 1 2 4 chunks +12 lines, -175 lines 0 comments Download
M native_client_sdk/src/doc/PRESUBMIT.py View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M native_client_sdk/src/doc/README View 2 chunks +10 lines, -31 lines 0 comments Download
M native_client_sdk/src/doc/doxygen/generate_docs.py View 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/rest-devsite-examples.rst View 7 chunks +11 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
6 years, 10 months ago (2014-02-25 19:35:23 UTC) #1
Sam Clegg
lgtm
6 years, 10 months ago (2014-02-25 19:42:29 UTC) #2
JF
https://codereview.chromium.org/180003003/diff/1/native_client_sdk/src/doc/Makefile File native_client_sdk/src/doc/Makefile (right): https://codereview.chromium.org/180003003/diff/1/native_client_sdk/src/doc/Makefile#newcode31 native_client_sdk/src/doc/Makefile:31: @echo " serve start python web server for chromesite ...
6 years, 10 months ago (2014-02-25 19:44:56 UTC) #3
binji
https://codereview.chromium.org/180003003/diff/1/native_client_sdk/src/doc/Makefile File native_client_sdk/src/doc/Makefile (right): https://codereview.chromium.org/180003003/diff/1/native_client_sdk/src/doc/Makefile#newcode31 native_client_sdk/src/doc/Makefile:31: @echo " serve start python web server for chromesite ...
6 years, 10 months ago (2014-02-25 21:03:02 UTC) #4
JF
lgtm
6 years, 10 months ago (2014-02-25 21:07:23 UTC) #5
binji
6 years, 10 months ago (2014-02-25 22:08:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r253268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698