Consistently use on-heap collections for StyleRuleBase descendants.

Source/core/css/StyleSheetContents.h

Index: Source/core/css/StyleSheetContents.h
diff --git a/Source/core/css/StyleSheetContents.h b/Source/core/css/StyleSheetContents.h
index 1807fdf45143f8b8a746286ef4bb03596d47b60e..b9eb3842c10e5843e90e5a12f0c6a6d6bfa41f39 100644
--- a/Source/core/css/StyleSheetContents.h
+++ b/Source/core/css/StyleSheetContents.h
@@ -95,7 +95,7 @@ public:
 
     void setHasFontFaceRule(bool b) { m_hasFontFaceRule = b; }
     bool hasFontFaceRule() const { return m_hasFontFaceRule; }
-    void findFontFaceRules(Vector<const StyleRuleFontFace*>& fontFaceRules);
+    void findFontFaceRules(WillBeHeapVector<RawPtrWillBeMember<const StyleRuleFontFace> >& fontFaceRules);
 
     void parserAddNamespace(const AtomicString& prefix, const AtomicString& uri);
     void parserAppendRule(PassRefPtrWillBeRawPtr<StyleRuleBase>);
@@ -114,7 +114,7 @@ public:
 
     StyleSheetContents* parentStyleSheet() const;
     StyleRuleImport* ownerRule() const { return m_ownerRule; }
-    void clearOwnerRule() { m_ownerRule = 0; }
+    void clearOwnerRule() { m_ownerRule = nullptr; }

[haraken, 2014/02/26 02:20:13]

This is called from ~StyleRuleImport(). This is dangerous, since StyleRuleImport
is already on the heap. Probably you can remove clearOwnerRule() from
~StyleRuleImport().

[Vyacheslav Egorov (Chromium), 2014/02/26 13:12:24]

Good catch! I asked people to pay attention to finalizers and forgot to check
this myself.

 
     // Note that href is the URL that started the redirect chain that led to
     // this style sheet. This property probably isn't useful for much except
@@ -165,7 +165,7 @@ private:
 
     void clearCharsetRule();
 
-    StyleRuleImport* m_ownerRule;
+    RawPtrWillBeMember<StyleRuleImport> m_ownerRule;
 
     String m_originalURL;