Consistently use on-heap collections for StyleRuleBase descendants.

Source/core/css/PageRuleCollector.cpp

Index: Source/core/css/PageRuleCollector.cpp
diff --git a/Source/core/css/PageRuleCollector.cpp b/Source/core/css/PageRuleCollector.cpp
index e4494526d309633ba6ac5cbe251997f352fbce80..6021e3184c312c2805b05532c33c422041e16ed5 100644
--- a/Source/core/css/PageRuleCollector.cpp
+++ b/Source/core/css/PageRuleCollector.cpp
@@ -73,7 +73,7 @@ void PageRuleCollector::matchPageRules(RuleSet* rules)
         return;
 
     rules->compactRulesIfNeeded();
-    Vector<StyleRulePage*> matchedPageRules;
+    WillBeHeapVector<RawPtrWillBeMember<StyleRulePage> > matchedPageRules;

[haraken, 2014/02/26 02:20:13]

You might want to introduce typedef for
WillBeHeapVector<RawPtrWillBeMember<StyleRulePage>. For example,
StyleRulePageVector.

[Vyacheslav Egorov (Chromium), 2014/02/26 13:12:24]

It's somewhat obscure to have these typedef's because underlying data structure
names goes to the end instead of staying in-front. 

Though it helps to cut down the verbosity so I am not sure what I really would
prefer.

[haraken, 2014/02/26 13:23:49]

Yeah, we decided not to use typedef since it makes underlying data structure
obscure and cause unexpected bugs (forget tracing etc).

     matchPageRulesForList(matchedPageRules, rules->pageRules(), m_isLeftPage, m_isFirstPage, m_pageName);
     if (matchedPageRules.isEmpty())
         return;
@@ -104,7 +104,7 @@ static bool checkPageSelectorComponents(const CSSSelector* selector, bool isLeft
     return true;
 }
 
-void PageRuleCollector::matchPageRulesForList(Vector<StyleRulePage*>& matchedRules, const Vector<StyleRulePage*>& rules, bool isLeftPage, bool isFirstPage, const String& pageName)
+void PageRuleCollector::matchPageRulesForList(WillBeHeapVector<RawPtrWillBeMember<StyleRulePage> >& matchedRules, const WillBeHeapVector<RawPtrWillBeMember<StyleRulePage> >& rules, bool isLeftPage, bool isFirstPage, const String& pageName)
 {
     for (unsigned i = 0; i < rules.size(); ++i) {
         StyleRulePage* rule = rules[i];