Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1799993002: Remove unsupported font SVGFreeSans.svg and svg-font-support.html (Closed)

Created:
4 years, 9 months ago by pdr.
Modified:
4 years, 9 months ago
Reviewers:
fs, trchen
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unsupported font SVGFreeSans.svg and svg-font-support.html We have not supported svg fonts for a long time but left this test and svg font file. BUG=594570, 594589 Committed: https://crrev.com/802572da31184ac329d8935049e61e204fc74142 Cr-Commit-Position: refs/heads/master@{#381366}

Patch Set 1 #

Patch Set 2 : Reupload after git cl upload failure #

Total comments: 1

Patch Set 3 : Only remove test and svg font #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -609 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/resources/SVGFreeSans.svg View 1 chunk +0 lines, -517 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/svg-font-support.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/svg-font-support-expected.html View 1 2 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
pdr.
4 years, 9 months ago (2016-03-15 00:05:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799993002/20001
4 years, 9 months ago (2016-03-15 00:06:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 01:03:23 UTC) #6
fs
LGTM /w doubts https://codereview.chromium.org/1799993002/diff/20001/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t.svg File third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t.svg (right): https://codereview.chromium.org/1799993002/diff/20001/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t.svg#newcode38 third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t.svg:38: <g id="test-body-content" font-family="sans-serif" font-size="18"> I don't ...
4 years, 9 months ago (2016-03-15 08:19:51 UTC) #8
pdr.
On 2016/03/15 at 08:19:51, fs wrote: > LGTM /w doubts > > https://codereview.chromium.org/1799993002/diff/20001/third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t.svg > File ...
4 years, 9 months ago (2016-03-15 20:33:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799993002/40001
4 years, 9 months ago (2016-03-15 20:35:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/189418)
4 years, 9 months ago (2016-03-15 21:13:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799993002/40001
4 years, 9 months ago (2016-03-15 21:40:52 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-16 00:33:43 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 00:35:38 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/802572da31184ac329d8935049e61e204fc74142
Cr-Commit-Position: refs/heads/master@{#381366}

Powered by Google App Engine
This is Rietveld 408576698