Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1799973002: Store and use last base URL between DidStart / DidStopLoading (Closed)

Created:
4 years, 9 months ago by mnaganov (inactive)
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Store and use last base URL between DidStart / DidStopLoading As it turns out that the committed entry may omit the base URL if there has been a javascript: URL navigation after LoadDataWithBaseURL. Thus we have to store the base url on DidStartLoading and use it in DidStopLoading / DidFinishLoad. We have to preserve the old hack with SetToBaseURLForDataURLIfNeeded because if the base URL is not valid, DidFinishLoad doesn't receive it from the renderer. This change is a short-term workaround. The correct solution is to pass a flag that the load was through LoadDataWithBaseURL via Blink, so base URL can be restored correctly within NavigationController. BUG=594001 Review URL: https://codereview.chromium.org/1779363004 Cr-Commit-Position: refs/heads/master@{#381108} (cherry picked from commit ce1f4d009316d8f5f4c49b18e1bd94687d80c59d) Committed: https://chromium.googlesource.com/chromium/src/+/c278e82252a35dd31989c5e0b658b3d10788163d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 1 chunk +33 lines, -0 lines 0 comments Download
M content/browser/android/web_contents_observer_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/web_contents_observer_proxy.cc View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
mnaganov (inactive)
4 years, 9 months ago (2016-03-14 23:48:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c278e82252a35dd31989c5e0b658b3d10788163d.

Powered by Google App Engine
This is Rietveld 408576698