LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol.html - Issue 179993006: [New multicol] Eliminate the need for RenderMultiColumnBlock.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol.html

Issue 179993006: [New multicol] Eliminate the need for RenderMultiColumnBlock. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/multicol-becomes-regular-block-expected.html ('k') | LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol-expected.html » ('j') | LayoutTests/fast/multicol/newmulticol/table-cell.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Change regular block to multicol</title>

	5 <script>

	6 if (window.internals)

	7 internals.settings.setRegionBasedColumnsEnabled(true);

	8 function test() {

	9 var elm = document.getElementById('elm');

	10 elm.offsetTop; // trigger layout

	11 elm.style.WebkitColumns = 4;
	eseidel 2014/02/25 23:37:09 Why do we set WebKitColumsn here? Why do we set WebKitColumsn here? mstensho (USE GERRIT) 2014/02/25 23:52:47 That's still the name of the property in Blink. It Show quoted text On 2014/02/25 23:37:09, eseidel wrote: > Why do we set WebKitColumsn here? That's still the name of the property in Blink. It's still not unprefixed. I plan to fix that once the old multicol code is gone.
	12 elm.style.columns = 4;

	13 }

	14 </script>

	15 </head>

	16 <body onload="test()">

	17 <p>You should see the word 'PASS' below.</p>

	18 <div style="font-family:monospace; float:left;">

	19 <div id="elm" style="-webkit-column-gap:0; column-gap:0; orphans:1; widows:1;">

	20 P<br>

	21 A<br>

	22 S<br>

	23 S<br>

	24 </div>

	25 </div>

	26 </body>

	27 </html>

OLD	NEW