Make kExposeInternalsForTesting usable (again) for interactive content_shell.

Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.

So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).

For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
Committed: https://crrev.com/756abda6b173d7b698bf43a0726e43eaab8c03dd
Cr-Commit-Position: refs/heads/master@{#381330}

[Łukasz Anforowicz, 2016-03-14 21:55:59]

Description was changed from

==========
Make kExposeInternalsForTesting usable for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.


So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).


For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
==========

to

==========
Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.


So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).


For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
==========

[Łukasz Anforowicz, 2016-03-14 21:56:06]

Description was changed from

==========
Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.


So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).


For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
==========

to

==========
Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.


So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).


For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
==========

[Łukasz Anforowicz, 2016-03-14 21:56:13]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 21:56:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799923002/1

[commit-bot: I haz the power, 2016-03-14 22:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 22:04:49]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Łukasz Anforowicz, 2016-03-14 22:07:58]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 22:08:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799923002/20001

[commit-bot: I haz the power, 2016-03-14 23:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 23:16:46]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-03-14 23:25:16]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-14 23:25:17]

jochen@, could you please take a look?

I think the first thing to do would is to fix the usecase that
iclelland@chromium.org has run into in https://crbug.com/594566 (this CL fixes
this usecase).  Afterwards we can argue whether the remaining flags make sense
for interactive content_shell or not (it is probably okay to leave them in
layout_test-specific parts of content-shell, but I would appreciate explicit ack
from you here :-).

[jochen (gone - plz use gerrit), 2016-03-15 21:00:52]

lgtm

[Łukasz Anforowicz, 2016-03-15 21:53:29]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-03-15 21:53:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799923002/20001

[commit-bot: I haz the power, 2016-03-15 21:59:01]

Description was changed from

==========
Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.


So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).


For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
==========

to

==========
Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.


So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).


For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
==========

[commit-bot: I haz the power, 2016-03-15 21:59:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-15 22:00:45]

Description was changed from

==========
Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.


So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).


For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566
==========

to

==========
Make kExposeInternalsForTesting usable again for interactive content_shell.

In https://crrev.com/1763113002 I've tried to separate
layout-test-specific cmdline switches into a separate header file and
handle some of them under
LayoutTestContentBrowserClient::AppendExtraCommandLineSwitches rather
than ShellContentBrowserClient::AppendExtraCommandLineSwitches.  This
was wrong - this meant that devs cannot pass these switches when
debugging via content_shell running in interactive / non-layout-test
mode.

So - the current CL undoes part of https://crrev.com/1763113002 and
restores processing of some of the switches back to
ShellContentBrowserClient:

- kExposeInternalsForTesting - this is useful for debugging layout tests
  (see https://crbug.com/594566).

For now it is okay to leave propagation of the following switches in
LayoutTestContentBrowserClient (because moving them in
https://crrev.com/1763113002 was not a regression as explained below):

- kStableReleaseMode - it only has effect if used together with
  --run-layout-test switch (i.e. see how
  ShellMainDelegate::BasicStartupComplete first checks
  switches::kRunLayoutTest before checking switches::kStableReleaseMode
  in a nested if).

- kEnableLeakDetection only affects BlinkTestController and
  LayoutTestContentBrowserClient so it won't have any effect without
  --run-layout-test switch.

- kEnableFontAntialiasing and kAlwaysUseComplexText only affects
  LayoutTestContentBrowserClient and LayoutTestRenderProcessObserver so
  it won't have any effect without --run-layout-test switch.

BUG=594566

Committed: https://crrev.com/756abda6b173d7b698bf43a0726e43eaab8c03dd
Cr-Commit-Position: refs/heads/master@{#381330}
==========

[commit-bot: I haz the power, 2016-03-15 22:00:46]

Patchset 2 (id:??) landed as
https://crrev.com/756abda6b173d7b698bf43a0726e43eaab8c03dd
Cr-Commit-Position: refs/heads/master@{#381330}