Settings People Revamp: Easy Unlock: Add basic UI

chrome/browser/resources/settings/people_page/people_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-people-page' is the settings page containing sign-in settings.
  *
  * Example:
  *
  *    <iron-animated-pages>
  *      <settings-people-page prefs="{{prefs}}"></settings-people-page>
  *      ... other pages ...
  *    </iron-animated-pages>
  */
 Polymer({
   is: 'settings-people-page',
 
   behaviors: [
     I18nBehavior,
+    WebUIListenerBehavior,
   ],
 
   properties: {
     /**
      * The current active route.
      */
     currentRoute: {
       type: Object,
       notify: true,
     },
@@ skipping 16 matching lines @@
      * The currently selected profile icon URL. May be a data URL.
      * @private {string}
      */
     profileIconUrl_: String,
 
     /**
      * The current profile name.
      * @private {string}
      */
     profileName_: String,
+
+<if expr="chromeos">
+    /**
+     * True if Easy Unlock is allowed on this machine.
+     * @private {boolean}
+     */
+    easyUnlockAllowed_: {

[dpapad, 2016/03/15 00:44:27]

Nit: Does the value of this ever change? If not, should we also add "readonly:
true"?

[tommycli, 2016/03/15 18:58:27]

Done.

+      type: Boolean,
+      value: function() {
+        return loadTimeData.getBoolean('easyUnlockAllowed');
+      },
+    },
+
+    /**
+     * True if Easy Unlock is enabled.
+     * @private {boolean}
+     */
+    easyUnlockEnabled_: {
+      type: Boolean,
+      value: function() {
+        return loadTimeData.getBoolean('easyUnlockEnabled');
+      },
+    },
+</if>
   },
 
   /** @override */
-  created: function() {
+  attached: function() {
     settings.SyncPrivateApi.getProfileInfo(this.handleProfileInfo_.bind(this));
     settings.SyncPrivateApi.getSyncStatus(
         this.handleSyncStatusFetched_.bind(this));
+
+<if expr="chromeos">
+    this.addWebUIListener(

[dpapad, 2016/03/15 00:44:27]

IIUC, this is listener is not needed if easyUnlockAllowed_ is false, and that
value can never change. If that is true, let's wrap this

if (this.easyUnlockAllowed_) {
  this.addWebUIListener(...);
}

[tommycli, 2016/03/15 18:58:27]

Done.

+        'easy-unlock-enabled-status',
+        this.handleEasyUnlockEnabledStatusChanged_.bind(this));

[dpapad, 2016/03/15 00:44:27]

Nit (optional): Given that handleEasyUnlockEnabledStatusChanged_ is a single
line method, and that it is wrapped in <if>, how about simply inlining it here
as an anonymous function? This way there is no need for the 2nd <if> a few lines
below.

[tommycli, 2016/03/15 18:58:27]

I should have mentioned: I will also be doing a cr.sendWithPromise with this as
a the callback fn in the next CL.

+</if>
   },
 
   /**
    * Handler for when the profile's icon and name is updated.
    * @private
    * @param {!string} name
    * @param {!string} iconUrl
    */
   handleProfileInfo_: function(name, iconUrl) {
     this.profileName_ = name;
     this.profileIconUrl_ = iconUrl;
   },
 
   /**
    * Handler for when the sync state is pushed from settings.SyncPrivateApi.
    * @private
    */
   handleSyncStatusFetched_: function(syncStatus) {
     this.syncStatus = syncStatus;
 
     // TODO(tommycli): Remove once we figure out how to refactor the sync
     // code to not include HTML in the status messages.
     this.$.syncStatusText.innerHTML = syncStatus.statusText;
   },
 
+<if expr="chromeos">
+  /**
+   * Handler for when the Easy Unlock enabled status has changed.
+   * @private
+   */
+  handleEasyUnlockEnabledStatusChanged_: function(easyUnlockEnabled) {
+    this.easyUnlockEnabled_ = easyUnlockEnabled;
+  },
+</if>
+
   /** @private */
   onActionLinkTap_: function() {
     settings.SyncPrivateApi.showSetupUI();
   },
 
   /** @private */
   onPictureTap_: function() {
 <if expr="chromeos">
     this.$.pages.setSubpageChain(['changePicture']);
 </if>
@@ skipping 52 matching lines @@
 
   /**
    * @private
    * @return {boolean}
    */
   isAdvancedSyncSettingsVisible_: function(syncStatus) {
     return syncStatus && syncStatus.signedIn && !syncStatus.managed &&
            syncStatus.syncSystemEnabled;
   },
 });