Deferred image decoding to support animated GIFs

Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp

Index: Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp
diff --git a/Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp b/Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp
index d4f704b216f2d7564c02c687b0116d63543a0af3..8c3ad27d8ca5607d927fcbd4b312388da1a106c7 100644
--- a/Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp
+++ b/Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp
@@ -30,12 +30,12 @@
 #include "core/platform/chromium/TraceEvent.h"
 #include "core/platform/graphics/chromium/ImageDecodingStore.h"
 #include "core/platform/graphics/chromium/ImageFrameGenerator.h"
-#include <wtf/MainThread.h>
 
 namespace WebCore {
 
-LazyDecodingPixelRef::LazyDecodingPixelRef(PassRefPtr<ImageFrameGenerator> frameGenerator, const SkISize& scaledSize, const SkIRect& scaledSubset)
+LazyDecodingPixelRef::LazyDecodingPixelRef(PassRefPtr<ImageFrameGenerator> frameGenerator, const SkISize& scaledSize, size_t index, const SkIRect& scaledSubset)
     : m_frameGenerator(frameGenerator)
+    , m_frameIndex(index)
     , m_scaledSize(scaledSize)
     , m_scaledSubset(scaledSubset)
     , m_lockedCachedImage(0)
@@ -76,16 +76,15 @@ void* LazyDecodingPixelRef::onLockPixels(SkColorTable**)
 {
     TRACE_EVENT_ASYNC_BEGIN0("webkit", "LazyDecodingPixelRef::lockPixels", this);
 
-    m_mutex.lock();
     ASSERT(!m_lockedCachedImage);
 
-    if (!ImageDecodingStore::instance()->lockCache(m_frameGenerator.get(), m_scaledSize, 0, &m_lockedCachedImage))
+    if (!ImageDecodingStore::instance()->lockCache(m_frameGenerator.get(), m_scaledSize, m_frameIndex, &m_lockedCachedImage))
         m_lockedCachedImage = 0;
 
     // Use ImageFrameGenerator to generate the image. It will lock the cache
     // entry for us.
     if (!m_lockedCachedImage)
-        m_lockedCachedImage = m_frameGenerator->decodeAndScale(m_scaledSize);
+        m_lockedCachedImage = m_frameGenerator->decodeAndScale(m_scaledSize, m_frameIndex);
 
     if (!m_lockedCachedImage)
         return 0;
@@ -101,7 +100,6 @@ void LazyDecodingPixelRef::onUnlockPixels()
         ImageDecodingStore::instance()->unlockCache(m_frameGenerator.get(), m_lockedCachedImage);
         m_lockedCachedImage = 0;
     }
-    m_mutex.unlock();
 
     TRACE_EVENT_ASYNC_END0("webkit", "LazyDecodingPixelRef::lockPixels", this);
 }
@@ -113,18 +111,13 @@ bool LazyDecodingPixelRef::onLockPixelsAreWritable() const
 
 bool LazyDecodingPixelRef::MaybeDecoded()
 {
-    return ImageDecodingStore::instance()->isCached(m_frameGenerator.get(), m_scaledSize, 0);
+    return ImageDecodingStore::instance()->isCached(m_frameGenerator.get(), m_scaledSize, m_frameIndex);
 }
 
 bool LazyDecodingPixelRef::PrepareToDecode(const LazyPixelRef::PrepareParams& params)
 {
-    // TODO: check if only a particular rect is available in image cache.
-    UNUSED_PARAM(params);
-    const ScaledImageFragment* cachedImage = 0;
-    bool cached = ImageDecodingStore::instance()->lockCache(m_frameGenerator.get(), m_scaledSize, 0, &cachedImage);
-    if (cached)
-        ImageDecodingStore::instance()->unlockCache(m_frameGenerator.get(), cachedImage);
-    return cached;
+    ASSERT(false);

[Stephen White, 2013/07/09 15:01:20]

Is this method still called anywhere? Or just not on this subclass?

[Alpha Left Google, 2013/07/09 19:20:22]

No it's not called anywhere, I'll remove it in next pass since it involves
removing the pure virtual method from .h file in skia/ext.

+    return false;
 }
 
 void LazyDecodingPixelRef::Decode()