Issue 179983002: initialize v8::Private with v8::String

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179983002: initialize v8::Private with v8::String (Closed)

Created:
6 years, 9 months ago by dcarney

Modified:
6 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

initialize v8::Private with v8::String R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19741

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -10 lines)			Patch
M	include/v8.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+2 lines, -7 lines	1 comment	Download
M	test/cctest/test-api.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://codereview.chromium.org/179983002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/179983002/diff/1/src/api.cc#newcode5987 src/api.cc:5987: Isolate* isolate, Local<String> name) { Nit: remove line ...

6 years, 9 months ago (2014-02-25 15:43:47 UTC) #2

dcarney

6 years, 9 months ago (2014-03-10 08:21:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19741 (presubmit successful).

Expand Messages | Collapse Messages