New Zip::ZipFromMemory API.

third_party/zlib/google/zip.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_ZLIB_GOOGLE_ZIP_H_
 #define THIRD_PARTY_ZLIB_GOOGLE_ZIP_H_
 
+#include <map>
+#include <vector>
+
 #include "base/callback.h"
 #include "base/files/file_path.h"
 
+namespace base {
+class RefCountedMemory;
+}
+
 namespace zip {
 
 // Zip the contents of src_dir into dest_file. src_path must be a directory.
 // An entry will *not* be created in the zip for the root folder -- children
 // of src_dir will be at the root level of the created zip. For each file in
 // src_dir, include it only if the callback |filter_cb| returns true. Otherwise
 // omit it.
 typedef base::Callback<bool(const base::FilePath&)> FilterCallback;
 bool ZipWithFilterCallback(const base::FilePath& src_dir,
                            const base::FilePath& dest_file,
                            const FilterCallback& filter_cb);
 
 // Convenience method for callers who don't need to set up the filter callback.
 // If |include_hidden_files| is true, files starting with "." are included.
 // Otherwise they are omitted.
 bool Zip(const base::FilePath& src_dir, const base::FilePath& dest_file,
          bool include_hidden_files);
 
 #if defined(OS_POSIX)
 // Zips files listed in |src_relative_paths| to destination specified by file
 // descriptor |dest_fd|. The paths listed in |src_relative_paths| are relative
 // to the |src_dir| and will be used as the file names in the created zip file.
 // All source paths must be under |src_dir| in the file system hierarchy.
 bool ZipFiles(const base::FilePath& src_dir,
               const std::vector<base::FilePath>& src_relative_paths,
               int dest_fd);
 #endif  // defined(OS_POSIX)
 
+// Adds to |zip_file| files using contents from memory. |zip_file| is created if
+// it does not exist. |files| contains a map with the file path to
+// be stored in the zip file plus its contents. The FilePath in |files| may not
+// be empty, absolute or contain a '..' component, else the function fails.
+// The paths must therefore be relative and preferably canonicalized.
+// Calling this with an empty |files| has no effect.
+//
+// If |append| is true, the new files are appended to an already existing file,
+// if any. Else, the file is recreated from scratch, meaning, all previous
+// contents are deleted without the possibility of recovery.
+//
+// If the RefCountedMemory in |files| is NULL, the file is removed from the zip
+// archive. If the RefCountedMemory in |files| is not NULL, a file will be
+// created with those contents. The contents can have a size of 0 bytes.
+// Note: the data passed in |files| is copied. This function does not keep any
+// references to the original data after it returns.
+//
+// If the FilePath ends with a path separator (a slash), a folder is created.
+// Note: the contents for a folder must be either NULL or 0-byte big, so the
+// folder will be removed or added, respectively.
+typedef std::map<base::FilePath, scoped_refptr<base::RefCountedMemory> >
+    ZipContents;
+bool ZipFromMemory(const base::FilePath& zip_path,

[satorux1, 2014/02/26 04:05:47]

I think it's not a good idea to add new APIs in this file.

A cleaner approach would be to first introduce zip_writer{.h,.cc,_unittest.cc}
like we did for zip_reader* to factor out zipping code.

[João Eiras, 2014/02/26 17:35:38]

Which APIs would belong there then ? All the zip::Zip* functions ?

[satorux1, 2014/02/27 06:57:00]

Here's what I meant:

1) zip.h just contains a bunch of functions. 
2) If we are to add more features for zipping, would be nicer to have a class
3) Which we did for unzipping code, with ZipReader
https://codereview.chromium.org/8508003
4) So my suggestion was to introduce ZipWriter class and factor out zipping code
into the new class, that would give cleaner implementation and API.

+                   const ZipContents& files,
+                   bool append);
+
 // Unzip the contents of zip_file into dest_dir.
 bool Unzip(const base::FilePath& zip_file, const base::FilePath& dest_dir);
 
 }  // namespace zip
 
 #endif  // THIRD_PARTY_ZLIB_GOOGLE_ZIP_H_