New Zip::ZipFromMemory API.

third_party/zlib/contrib/minizip/unzip.c

 /* unzip.c -- IO for uncompress .zip files using zlib
    Version 1.1, February 14h, 2010
    part of the MiniZip project - ( http://www.winimage.com/zLibDll/minizip.html )
 
          Copyright (C) 1998-2010 Gilles Vollant (minizip) ( http://www.winimage.com/zLibDll/minizip.html )
 
          Modifications of Unzip for Zip64
          Copyright (C) 2007-2008 Even Rouault
 
          Modifications for Zip64 support on both zip and unzip
@@ skipping 1687 matching lines @@
 
     if ((pfile_in_zip_read_info->read_buffer == NULL))
         return UNZ_END_OF_LIST_OF_FILE;
     if (len==0)
         return 0;
 
     pfile_in_zip_read_info->stream.next_out = (Bytef*)buf;
 
     pfile_in_zip_read_info->stream.avail_out = (uInt)len;
 
-    if ((len>pfile_in_zip_read_info->rest_read_uncompressed) &&
-        (!(pfile_in_zip_read_info->raw)))
-        pfile_in_zip_read_info->stream.avail_out =
-            (uInt)pfile_in_zip_read_info->rest_read_uncompressed;

[satorux1, 2014/02/26 04:05:47]

why was this part removed?

[João Eiras, 2014/02/26 17:35:38]

From the review description 

"A bug in unzip.c was fixed that would cause uncompressing a file bigger than 
the uncompressed size declared in the zip file's metadata to fail with a CRC 
error."

This fix is verified by the new test in zip_reader_unittest.cc.

[satorux1, 2014/02/27 06:57:00]

Is this issue fixed in the upstream? Otherwise, would it be possible to upstream
the change to the zlib project? 

[João Eiras, 2014/02/27 17:12:17]

unzip.c is from the minizip project. I tried to contact them but the project is
IMO literally dead (no activity). So, someone took the liberty to fork it and
continue working on it, and I sent him my patches
https://github.com/nmoinvaz/minizip 

-
     if ((len>pfile_in_zip_read_info->rest_read_compressed+
            pfile_in_zip_read_info->stream.avail_in) &&
          (pfile_in_zip_read_info->raw))
         pfile_in_zip_read_info->stream.avail_out =
             (uInt)pfile_in_zip_read_info->rest_read_compressed+
             pfile_in_zip_read_info->stream.avail_in;
 
     while (pfile_in_zip_read_info->stream.avail_out>0)
     {
         if ((pfile_in_zip_read_info->stream.avail_in==0) &&
@@ skipping 393 matching lines @@
                                               &s->cur_file_info_internal,
                                               NULL,0,NULL,0,NULL,0);
     s->current_file_ok = (err == UNZ_OK);
     return err;
 }
 
 extern int ZEXPORT unzSetOffset (unzFile file, uLong pos)
 {
     return unzSetOffset64(file,pos);
 }