Issue 17996003: Revert "Improve WTF::HashTable performance by changing probing method"

Issue 17996003: Revert "Improve WTF::HashTable performance by changing probing method" (Closed)

Created:
7 years, 5 months ago by Timothy Loh

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

Revert "Improve WTF::HashTable performance by changing probing method" This reverts https://codereview.chromium.org/17583004/ The perf bots didn't have the same improvement that I was seeing when I ran perf tests locally on a Nexus 7 and this might have even made performance worse. Also change k == 0 to !k for passing style check BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153142

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -31 lines)			Patch
M	LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/wtf/HashTable.h	View	14 chunks	+34 lines, -21 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Timothy Loh

On 2013/06/27 05:11:04, abarth wrote: > Why do the grid test change? The computed styles ...

7 years, 5 months ago (2013-06-27 07:31:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/17996003/1

7 years, 5 months ago (2013-06-27 07:32:25 UTC) #5

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=10869

7 years, 5 months ago (2013-06-27 08:57:03 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/17996003/1

7 years, 5 months ago (2013-06-27 13:31:13 UTC) #7

Message was sent while issue was closed.

Change committed as 153142

Expand Messages | Collapse Messages