Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1799423003: Apply WebSettings before initializing the main frame. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply WebSettings before initializing the main frame. Some settings need to be applied before initializing the main frame, since they affect the creation of the initial empty document. BUG=594383 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0ff94cfc829f6df331dd71df1eef201e06cca36c Cr-Commit-Position: refs/heads/master@{#381327}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : Layout test. #

Patch Set 4 : Fix expectations #

Patch Set 5 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -26 lines) Patch
M content/renderer/render_view_impl.cc View 1 3 chunks +27 lines, -26 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Window/file-origin-window-open.html View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Window/file-origin-window-open-expected.txt View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Window/resources/file-origin-window-open-frame.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dcheng
https://codereview.chromium.org/1799423003/diff/20001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/1799423003/diff/20001/content/renderer/render_view_impl.cc#newcode772 content/renderer/render_view_impl.cc:772: UpdateWebViewWithDeviceScaleFactor(); One might wonder: why are these here? Answer: ...
4 years, 9 months ago (2016-03-15 08:33:54 UTC) #4
jochen (gone - plz use gerrit)
test? :)
4 years, 9 months ago (2016-03-15 08:36:14 UTC) #5
dcheng
On 2016/03/15 at 08:36:14, jochen wrote: > test? :) Done.
4 years, 9 months ago (2016-03-15 09:27:55 UTC) #6
dcheng
On 2016/03/15 at 09:27:55, dcheng wrote: > On 2016/03/15 at 08:36:14, jochen wrote: > > ...
4 years, 9 months ago (2016-03-15 09:28:25 UTC) #7
dcheng
On 2016/03/15 at 09:28:25, dcheng wrote: > On 2016/03/15 at 09:27:55, dcheng wrote: > > ...
4 years, 9 months ago (2016-03-15 09:31:06 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-15 20:59:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799423003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799423003/80001
4 years, 9 months ago (2016-03-15 21:07:03 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-15 21:51:04 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 21:52:18 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0ff94cfc829f6df331dd71df1eef201e06cca36c
Cr-Commit-Position: refs/heads/master@{#381327}

Powered by Google App Engine
This is Rietveld 408576698