Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 179933002: Add a new configuration 'Profile' when building for iOS (Closed)

Created:
6 years, 10 months ago by sdefresne
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a new configuration 'Profile' when building for iOS When running Instruments, it is better to use a Release build, but with a dSYM file. So introduce a new configuration 'Profile' based on 'Release' that also generates a dSYM file. This uses a separate configuration because Instruments needs a real dSYM file, and generating it with dsymutil is slow. Moreover, it is not possible to build a dSYM file from the Release build, and profiling a Debug build is not really representative of real usage. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sdefresne
Please take a look.
6 years, 10 months ago (2014-02-25 14:23:44 UTC) #1
lliabraa
lgtm
6 years, 10 months ago (2014-02-25 15:33:21 UTC) #2
blundell
LGTM
6 years, 10 months ago (2014-02-25 15:38:30 UTC) #3
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 10 months ago (2014-02-25 17:33:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/179933002/1
6 years, 10 months ago (2014-02-25 17:34:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/179933002/1
6 years, 10 months ago (2014-02-25 21:48:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/179933002/1
6 years, 10 months ago (2014-02-25 22:13:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/179933002/1
6 years, 10 months ago (2014-02-25 23:17:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/179933002/1
6 years, 10 months ago (2014-02-26 00:04:11 UTC) #9
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:34:20 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 05:34:50 UTC) #11
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:42:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/179933002/1
6 years, 10 months ago (2014-02-26 05:51:19 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 14:33:00 UTC) #14
Message was sent while issue was closed.
Change committed as 253444

Powered by Google App Engine
This is Rietveld 408576698