Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Issue 17993005: Enable profile shortcut manager for windows when --show-app-list switch is enabled (Closed)

Created:
7 years, 5 months ago by calamity
Modified:
7 years, 5 months ago
Reviewers:
gab, sail, huangs
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable profile shortcut manager for windows when --show-app-list switch is enabled. This was originally to prevent shortcuts from being created on first run of the standalone app launcher. Since the standalone app launcher no longer exists, neither does this issue. BUG=167984 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
calamity
7 years, 5 months ago (2013-06-27 08:09:32 UTC) #1
gab
lgtm if description is accurate. +huangs who introduced this in http://crrev.com/188121 Is there a bug ...
7 years, 5 months ago (2013-06-27 11:54:48 UTC) #2
sail
lgtm (+1 to having a bug number)
7 years, 5 months ago (2013-06-27 18:04:48 UTC) #3
huangs
LGTM.
7 years, 5 months ago (2013-06-28 17:19:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/17993005/1
7 years, 5 months ago (2013-07-01 02:54:12 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-01 07:28:41 UTC) #6
Message was sent while issue was closed.
Change committed as 209381

Powered by Google App Engine
This is Rietveld 408576698