OLD | NEW |
---|---|
1 /* | 1 /* |
2 * Copyright (C) 2013 Google Inc. All rights reserved. | 2 * Copyright (C) 2013 Google Inc. All rights reserved. |
3 * | 3 * |
4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
6 * met: | 6 * met: |
7 * | 7 * |
8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
(...skipping 13 matching lines...) Expand all Loading... | |
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
29 */ | 29 */ |
30 | 30 |
31 #include "config.h" | 31 #include "config.h" |
32 #include "V8PromiseResolver.h" | 32 #include "V8PromiseResolver.h" |
33 | 33 |
34 #include "bindings/v8/V8Binding.h" | |
35 #include "bindings/v8/custom/V8PromiseCustom.h" | |
34 #include <v8.h> | 36 #include <v8.h> |
35 | 37 |
36 namespace WebCore { | 38 namespace WebCore { |
39 | |
40 void V8PromiseResolver::fulfillMethodCustom(const v8::FunctionCallbackInfo<v8::V alue>& args) | |
41 { | |
42 v8::Isolate* isolate = args.GetIsolate(); | |
43 v8::Local<v8::Value> result = v8::Undefined(); | |
haraken
2013/06/27 06:55:56
You don't need to set v8::Undefined().
yhirano
2013/06/27 09:29:23
Done.
| |
44 if (args.Length() > 0 && !args[0].IsEmpty()) | |
haraken
2013/06/27 06:55:56
Do you need to check !args[0].IsEmpty()? Normally
yhirano
2013/06/27 09:29:23
Done.
| |
45 result = args[0]; | |
46 v8::Local<v8::Object> resolver = args.Holder(); | |
47 ASSERT(!resolver.IsEmpty()); | |
48 v8SetReturnValue(args, v8::Undefined()); | |
haraken
2013/06/27 06:55:56
Remove this. v8::Undefined() is set by default.
yhirano
2013/06/27 09:29:23
Done.
| |
49 V8PromiseCustom::fulfillResolver(resolver, result, V8PromiseCustom::Asynchro nous, isolate); | |
50 } | |
51 | |
52 void V8PromiseResolver::rejectMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& args) | |
53 { | |
54 v8::Isolate* isolate = args.GetIsolate(); | |
55 v8::Local<v8::Value> result = v8::Undefined(); | |
haraken
2013/06/27 06:55:56
Ditto.
yhirano
2013/06/27 09:29:23
Done.
| |
56 if (args.Length() > 0 && !args[0].IsEmpty()) | |
haraken
2013/06/27 06:55:56
Ditto.
yhirano
2013/06/27 09:29:23
Done.
| |
57 result = args[0]; | |
58 v8::Local<v8::Object> resolver = args.Holder(); | |
59 ASSERT(!resolver.IsEmpty()); | |
60 v8SetReturnValue(args, v8::Undefined()); | |
haraken
2013/06/27 06:55:56
Ditto.
yhirano
2013/06/27 09:29:23
Done.
| |
61 V8PromiseCustom::rejectResolver(resolver, result, V8PromiseCustom::Asynchron ous, isolate); | |
62 } | |
63 | |
37 } // namespace WebCore | 64 } // namespace WebCore |
OLD | NEW |