Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1799283002: Delete support for source mirrors (Closed)

Created:
4 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : new attempt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4997 lines) Patch
D pkg/compiler/lib/src/mirrors/analyze.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
D pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart View 1 1 chunk +0 lines, -286 lines 0 comments Download
D pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart View 1 1 chunk +0 lines, -255 lines 0 comments Download
D pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart View 1 1 chunk +0 lines, -227 lines 0 comments Download
D pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 1 chunk +0 lines, -480 lines 0 comments Download
D pkg/compiler/lib/src/mirrors/dart2js_type_mirrors.dart View 1 1 chunk +0 lines, -497 lines 0 comments Download
D pkg/compiler/lib/src/mirrors/mirrors_util.dart View 1 1 chunk +0 lines, -425 lines 0 comments Download
D pkg/compiler/lib/src/mirrors/source_mirrors.dart View 1 1 chunk +0 lines, -255 lines 0 comments Download
M tests/compiler/dart2js/analyze_test_test.dart View 1 3 chunks +1 line, -11 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 2 chunks +0 lines, -22 lines 0 comments Download
D tests/compiler/dart2js/mirror_system_helper.dart View 1 chunk +0 lines, -139 lines 0 comments Download
D tests/compiler/dart2js/mirrors/class_mirror_type_variables_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/compiler/dart2js/mirrors/default_value_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D tests/compiler/dart2js/mirrors/field_parameter_type_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_exports_hidden_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_exports_shown_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_hidden_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_prefixed_show_hide_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_prefixed_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_shown_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/mirrors_reader_test.dart View 1 chunk +0 lines, -142 lines 0 comments Download
D tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/compiler/dart2js/mirrors/relation_assignable_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/relation_subclass_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/relation_subtype_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors_exports_test.dart View 1 chunk +0 lines, -183 lines 0 comments Download
D tests/compiler/dart2js/mirrors_lookup_test.dart View 1 chunk +0 lines, -263 lines 0 comments Download
D tests/compiler/dart2js/mirrors_metadata_test.dart View 1 chunk +0 lines, -86 lines 0 comments Download
D tests/compiler/dart2js/mirrors_mixin_test.dart View 1 chunk +0 lines, -240 lines 0 comments Download
D tests/compiler/dart2js/quarantined/mirrors_test.dart View 1 1 chunk +0 lines, -974 lines 0 comments Download
D tests/compiler/dart2js/strip_comment_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-14 22:46:07 UTC) #2
Johnni Winther
lgtm
4 years, 9 months ago (2016-03-15 08:24:52 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 6586b3696eae6f750644273ece5cb68dc3d304a5 (presubmit successful).
4 years, 9 months ago (2016-03-15 16:09:47 UTC) #5
Siggi Cherem (dart-lang)
I had to revert because the try-site needed it to generate an sdk.json file. I ...
4 years, 9 months ago (2016-03-15 19:55:32 UTC) #6
Siggi Cherem (dart-lang)
... submitting this again, now that I deleted the dependency on source-mirrors.
4 years, 7 months ago (2016-05-24 19:47:13 UTC) #7
Siggi Cherem (dart-lang)
4 years, 7 months ago (2016-05-24 20:05:53 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) manually as
ea5f49c96957f272e33348e3812b97457f946d85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698