third_party/WebKit/Source/core/page/CreateWindow.cpp - Issue 1799253002: Stricter user gestures for touch - measure and warn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 1799253002: Stricter user gestures for touch - measure and warn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/EventHandler.cpp ('K') | « third_party/WebKit/Source/core/loader/NavigationScheduler.cpp ('k') | third_party/WebKit/Source/platform/UserGestureIndicator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/CreateWindow.cpp

diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp

index 6b8f1697f905bf261c634a28d29602982326fca9..6a4f08c347020f358b35fe76cf88fc81d49a111e 100644

--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp

+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp

@@ -169,7 +169,7 @@ DOMWindow* createWindow(const String& urlString, const AtomicString& frameName,

// Records HasUserGesture before the value is invalidated inside createWindow(LocalFrame& openerFrame, ...).

// This value will be set in ResourceRequest loaded in a new LocalFrame.

- bool hasUserGesture = UserGestureIndicator::processingUserGesture();

+ bool hasUserGesture = UserGestureIndicator::processingUserGestureUntracked();

// We pass the opener frame for the lookupFrame in case the active frame is different from

// the opener frame, and the name references a frame relative to the opener frame.