third_party/WebKit/Source/core/loader/NavigationScheduler.cpp - Issue 1799253002: Stricter user gestures for touch - measure and warn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

Issue 1799253002: Stricter user gestures for touch - measure and warn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaks Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

index 94e7e6fc23441d022c34b7f8cc3261980170f5db..e46878f1cefa2153e795b4bc7d9aeb0937cdd777 100644

--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

@@ -323,7 +323,7 @@ bool NavigationScheduler::mustReplaceCurrentItem(LocalFrame* targetFrame)

{

// Non-user navigation before the page has finished firing onload should not create a new back/forward item.

// See https://webkit.org/b/42861 for the original motivation for this.

- if (!UserGestureIndicator::processingUserGesture() && !targetFrame->document()->loadEventFinished())

+ if (!targetFrame->document()->loadEventFinished() && !UserGestureIndicator::utilizeUserGesture())

return true;

// Navigation of a subframe during loading of an ancestor frame does not create a new back/forward item.