third_party/WebKit/Source/core/html/HTMLFormElement.cpp - Issue 1799253002: Stricter user gestures for touch - measure and warn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 1799253002: Stricter user gestures for touch - measure and warn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaks Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

index fc459a3c1102ca01938217eee7b1f83473882e35..a151b8b48d33312c7e93fe02b8476b50df76e60e 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

@@ -417,7 +417,7 @@ void HTMLFormElement::scheduleFormSubmission(RawPtr<FormSubmission> submission)

Frame* targetFrame = document().frame()->findFrameForNavigation(submission->target(), *document().frame());

if (!targetFrame) {

- if (!LocalDOMWindow::allowPopUp(*document().frame()) && !UserGestureIndicator::processingUserGesture())

+ if (!LocalDOMWindow::allowPopUp(*document().frame()) && !UserGestureIndicator::utilizeUserGesture())

return;

targetFrame = document().frame();

} else {

@@ -465,7 +465,7 @@ void HTMLFormElement::requestAutocomplete()

errorMessage = "requestAutocomplete: form is not owned by a displayed document.";

else if (!shouldAutocomplete())

errorMessage = "requestAutocomplete: form autocomplete attribute is set to off.";

- else if (!UserGestureIndicator::processingUserGesture())

+ else if (!UserGestureIndicator::utilizeUserGesture())

errorMessage = "requestAutocomplete: must be called in response to a user gesture.";

if (!errorMessage.isEmpty()) {