Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

Issue 1799253002: Stricter user gestures for touch - measure and warn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweaks Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/remoteplayback/RemotePlayback.h" 5 #include "modules/remoteplayback/RemotePlayback.h"
6 6
7 #include "bindings/core/v8/ScriptPromiseResolver.h" 7 #include "bindings/core/v8/ScriptPromiseResolver.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/events/Event.h" 9 #include "core/events/Event.h"
10 #include "core/html/HTMLMediaElement.h" 10 #include "core/html/HTMLMediaElement.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 return promise; 94 return promise;
95 } 95 }
96 96
97 ScriptPromise RemotePlayback::connect(ScriptState* scriptState) 97 ScriptPromise RemotePlayback::connect(ScriptState* scriptState)
98 { 98 {
99 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ; 99 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
100 ScriptPromise promise = resolver->promise(); 100 ScriptPromise promise = resolver->promise();
101 101
102 // TODO(avayvod): should we have a separate flag to disable the user gesture 102 // TODO(avayvod): should we have a separate flag to disable the user gesture
103 // requirement (for tests) or reuse the one for the PresentationRequest::sta rt()? 103 // requirement (for tests) or reuse the one for the PresentationRequest::sta rt()?
104 if (!UserGestureIndicator::processingUserGesture()) { 104 if (!UserGestureIndicator::utilizeUserGesture()) {
105 resolver->reject(DOMException::create(InvalidAccessError, "RemotePlaybac k::connect() requires user gesture.")); 105 resolver->reject(DOMException::create(InvalidAccessError, "RemotePlaybac k::connect() requires user gesture."));
106 return promise; 106 return promise;
107 } 107 }
108 108
109 if (m_state == WebRemotePlaybackState::Disconnected) { 109 if (m_state == WebRemotePlaybackState::Disconnected) {
110 m_connectPromiseResolvers.append(resolver); 110 m_connectPromiseResolvers.append(resolver);
111 m_mediaElement->requestRemotePlayback(); 111 m_mediaElement->requestRemotePlayback();
112 } else { 112 } else {
113 m_mediaElement->requestRemotePlaybackControl(); 113 m_mediaElement->requestRemotePlaybackControl();
114 resolver->resolve(false); 114 resolver->resolve(false);
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 DEFINE_TRACE(RemotePlayback) 165 DEFINE_TRACE(RemotePlayback)
166 { 166 {
167 visitor->trace(m_availabilityObjects); 167 visitor->trace(m_availabilityObjects);
168 visitor->trace(m_mediaElement); 168 visitor->trace(m_mediaElement);
169 visitor->trace(m_connectPromiseResolvers); 169 visitor->trace(m_connectPromiseResolvers);
170 RefCountedGarbageCollectedEventTargetWithInlineData<RemotePlayback>::trace(v isitor); 170 RefCountedGarbageCollectedEventTargetWithInlineData<RemotePlayback>::trace(v isitor);
171 DOMWindowProperty::trace(visitor); 171 DOMWindowProperty::trace(visitor);
172 } 172 }
173 173
174 } // namespace blink 174 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698