Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 1799253002: Stricter user gestures for touch - measure and warn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweaks Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2013 Google Inc. All rights reserved. 9 * Copyright (C) 2013 Google Inc. All rights reserved.
10 * 10 *
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 // node document: 221 // node document:
222 222
223 // The fullscreen element ready check returns false. 223 // The fullscreen element ready check returns false.
224 if (!fullscreenElementReady(element)) 224 if (!fullscreenElementReady(element))
225 break; 225 break;
226 226
227 // This algorithm is not allowed to show a pop-up: 227 // This algorithm is not allowed to show a pop-up:
228 // An algorithm is allowed to show a pop-up if, in the task in which t he algorithm is running, either: 228 // An algorithm is allowed to show a pop-up if, in the task in which t he algorithm is running, either:
229 // - an activation behavior is currently being processed whose click e vent was trusted, or 229 // - an activation behavior is currently being processed whose click e vent was trusted, or
230 // - the event listener for a trusted click event is being handled. 230 // - the event listener for a trusted click event is being handled.
231 if (!UserGestureIndicator::processingUserGesture()) { 231 if (!UserGestureIndicator::utilizeUserGesture()) {
232 String message = ExceptionMessages::failedToExecute("requestFullScre en", 232 String message = ExceptionMessages::failedToExecute("requestFullScre en",
233 "Element", "API can only be initiated by a user gesture."); 233 "Element", "API can only be initiated by a user gesture.");
234 document()->getExecutionContext()->addConsoleMessage( 234 document()->getExecutionContext()->addConsoleMessage(
235 ConsoleMessage::create(JSMessageSource, WarningMessageLevel, mes sage)); 235 ConsoleMessage::create(JSMessageSource, WarningMessageLevel, mes sage));
236 break; 236 break;
237 } 237 }
238 238
239 // Fullscreen is not supported. 239 // Fullscreen is not supported.
240 if (!fullscreenIsSupported(element.document())) 240 if (!fullscreenIsSupported(element.document()))
241 break; 241 break;
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 DEFINE_TRACE(Fullscreen) 611 DEFINE_TRACE(Fullscreen)
612 { 612 {
613 visitor->trace(m_fullScreenElement); 613 visitor->trace(m_fullScreenElement);
614 visitor->trace(m_fullScreenElementStack); 614 visitor->trace(m_fullScreenElementStack);
615 visitor->trace(m_eventQueue); 615 visitor->trace(m_eventQueue);
616 Supplement<Document>::trace(visitor); 616 Supplement<Document>::trace(visitor);
617 DocumentLifecycleObserver::trace(visitor); 617 DocumentLifecycleObserver::trace(visitor);
618 } 618 }
619 619
620 } // namespace blink 620 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698